Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] Surgery Fixes: Popup Walker #923

Merged
merged 10 commits into from
Nov 19, 2024
Merged

[Port] Surgery Fixes: Popup Walker #923

merged 10 commits into from
Nov 19, 2024

Conversation

Roudenn
Copy link
Contributor

@Roudenn Roudenn commented Nov 18, 2024

Port of da Simple-Station/Einstein-Engines#1240 and Simple-Station/Einstein-Engines#1241

🆑 Mocho, angenofallars, Rouden

  • add: Шадовкины теперь имеют собственные типы органов вместо человеческих.
  • add: Теперь можно оперировать некоторых животных!
  • add: Теперь удаление сердца или мозга из тела вызывает скорую смерть.
  • add: Во время хирургических операций всем видны всплывающие сообщения о проводимых действиях.
  • fix: Исправлены баги связанные с уничтожением торса (наверное).

gluesniffler and others added 10 commits November 15, 2024 19:08
Megasquached Surgery Updates

Quick patch to see if tests shut up

Please do not cherrypick this one yet.

Refactored body parts to use damageablecomponent

newmed health analyzer real, also refactors and some bugfixes
First in a series of PRs to introduce bugfixes and updates to Shitmed,
this will generally feature PRs from Goobstation or Backmen as well
since they are actively helping me maintain the code.

Usual Shoutouts:
Deltanedas: Goob-Station/Goob-Station#882

---

:cl: Mocho, Deltanedas
- add: You can now perform surgery as a monke. Rejoice.
- add: You can perform surgery on a lot of animals now, I missed a lot
of them so just ask if you want any particular critter to get it.
- tweak: Entities now perish after 60 seconds of losing their heart
and/or brain.
- fix: Entities properly take asphyxiation damage after losing their
brain.
- fix: Torsos being gibbable, which would break surgery or just about
anything.
- fix: Items not being removed from their respective slots if the parts
were gibbed rather than dropped.
- fix: Animal organs not being usable properly in surgeries
- fix: Cyborg limbs are now usable as pseudo-peg arm/legs.

---------

Signed-off-by: gluesniffler <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: goet <[email protected]>
Co-authored-by: Saphire Lattice <[email protected]>
Adds popups for surgery steps in Shitmed that every player within PVS
range can see. This allows other players to see if the correct procedure
is being performed. This PR also includes locale text for the new
procedures and steps in #1240.

**Remove Brain / Insert Brain**

https://github.com/user-attachments/assets/ac20afa1-df74-48ab-b1d5-2e9a273dfba2

<details><summary>See more</summary>

**Amputate Right Arm**

https://github.com/user-attachments/assets/17f78683-6d3b-44ee-aea3-bb6987844fdc

**Attach Right Arm**

https://github.com/user-attachments/assets/584d4da2-d8b0-4c82-a323-26636e7fa4b8

</details>

:cl: Skubman
- add: Surgery step descriptions (like making an incision,
removing/attaching limbs and organs) are now shown as popups to everyone
in range upon the start of the step. This makes it clear which surgical
procedure is being done and to which body part. No more stealthy
brain-stealing in front of everyone!
@Roudenn Roudenn requested a review from Rxup as a code owner November 18, 2024 18:55
@github-actions github-actions bot added Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation labels Nov 18, 2024
Copy link
Contributor

RSI Diff Bot; head commit 894aa89 merging into e85b474
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Backmen/Mobs/Species/Shadowkin/organs.rsi

State Old New Status
appendix Added
brain Added
core Added
ears Added
eyes Added
heart Added
kidneys Added
liver Added
lungs Added
stomach Added
tongue Added

Resources/Textures/Backmen/Mobs/Species/Shadowkin/parts.rsi

State Old New Status
eyes Added
full-nomarkings Added
full Added
head_f Added
head_m Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso_f Added
torso_m Added

@Rxup Rxup merged commit 0327a35 into Rxup:master Nov 19, 2024
12 checks passed
@Roudenn Roudenn deleted the surgery-portin branch November 20, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants