Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Weapon Safes are have Access. #1077

Closed
wants to merge 1 commit into from
Closed

[FIX] Weapon Safes are have Access. #1077

wants to merge 1 commit into from

Conversation

CatBackGround
Copy link
Contributor

@CatBackGround CatBackGround commented Feb 25, 2025 •
edited by coderabbitai bot
Loading

Описание PR

Пофиксил наследование у Оружейных Сейфов. Доступам быть.

Медиа

Тип PR

  • Feature
  • Fix
  • Tweak
  • Balance
  • Refactor
  • Port
  • Translate
  • Resprite

Изменения

Summary by CodeRabbit

  • Рефакторинг
    • Обновлена иерархическая классификация ряда элементов безопасности для повышения согласованности и улучшения структуры.

@CatBackGround CatBackGround requested a review from Rxup as a code owner February 25, 2025 05:39
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2025 •
edited
Loading

Walkthrough

В файле конфигурации обновлены значения атрибута parent для ряда сущностей. Ранее использовался родительский класс "GunSafe", который заменён на "GunSafeBaseSecure" для обеспечения единообразия иерархии. Остальные параметры, такие как BaseSecurityContraband, остались без изменений.

Changes

Файл Изменения
Resources/.../Lockers/security.yml Замена значения parent: "GunSafe" → "GunSafeBaseSecure" для 6 сущностей (GunSafeRifleAR18, GunSafeSubMachineGunVector, GunSafeShotgunShotgun39, GunSafeShotgunTrenchgun, GunSafeSubMachineGunMP5, GunSafeLaserCarbineUEG)

Poem

В мире YAML, где код мерцает в тишине,
Я, кролик, латаю баги в весёлой игре.
GunSafe уступил место новым корням,
GunSafeBaseSecure — как звезда во мраке ночных туч.
Прыгаю от счастья, словно в сказочном лугу!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Resources/Prototypes/_Backmen/Catalog/Fills/Lockers/security.yml (1)

61-62: Проверка формата значения "parent" для GunSafeLaserCarbineUEG.
Значение обновлено на GunSafeBaseSecure, однако в отличие от других сущностей, здесь используется единичное значение, а не массив. Рекомендуется проверить, соответствует ли это требуемому формату или следует использовать массив для единообразия.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b0dae5a and e1673a6.

📒 Files selected for processing (1)
  • Resources/Prototypes/_Backmen/Catalog/Fills/Lockers/security.yml (6 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (2)
  • GitHub Check: Test Packaging
  • GitHub Check: build (ubuntu-latest)
🔇 Additional comments (5)
Resources/Prototypes/_Backmen/Catalog/Fills/Lockers/security.yml (5)

1-2: Обновление родительского класса для GunSafeRifleAR18 выполнено корректно.
Значение parent изменено на [GunSafeBaseSecure, BaseSecurityContraband], что соответствует новой модели безопасности.

13-14: Изменение родительского класса для GunSafeSubMachineGunVector выполнено правильно.
Новый массив [GunSafeBaseSecure, BaseSecurityContraband] отражает актуальные требования к иерархии наследования.

25-26: Корректное обновление для GunSafeShotgunShotgun39.
Использование [GunSafeBaseSecure, BaseSecurityContraband] обеспечивает единообразие с другими сущностями.

37-38: Обновление родительского класса для GunSafeShotgunTrenchgun выполнено корректно.
Новое значение [GunSafeBaseSecure, BaseSecurityContraband] соответствует обновленной политике безопасности.

49-50: Изменение для GunSafeSubMachineGunMP5 корректно.
Новое значение parent: [GunSafeBaseSecure, BaseSecurityContraband] соответствует измененным требованиям к наследованию.

@nomad0260
Copy link
Collaborator

#1049

@nomad0260 nomad0260 added the DONT MERGE Ноу, ноу, ноу, мистер, не совершайте ошибок. label Feb 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@CatBackGround
Copy link
Contributor Author

Сука быстрая...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Rxup Rxup Awaiting requested review from Rxup Rxup is a code owner

Assignees
No one assigned
Labels
DONT MERGE Ноу, ноу, ноу, мистер, не совершайте ошибок. No C# Нету кода. S: Merge Conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CatBackGround @nomad0260