Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[PORT] NanoСhat" #1060

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Revert "[PORT] NanoСhat" #1060

merged 1 commit into from
Feb 16, 2025

Conversation

Rxup
Copy link
Owner

@Rxup Rxup commented Feb 16, 2025

Reverts #1055

Summary by CodeRabbit

  • Refactor
    • Обновлён интерфейс: из карточек агентов убрано отображение номера, а вид логов упрощён для показа только актуальных данных.
  • Chores
    • Убран функционал чата и все относящиеся к нему элементы, что сокращает лишние опции на портативных устройствах.
    • Пересмотрены идентификационные карточки: добавлены новые типы для агентов, капитанов, сотрудников безопасности и посетителей.

Copy link
Contributor

coderabbitai bot commented Feb 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Внесены изменения, направленные на полное удаление функционала, связанного с NanoChat и обработкой числовых данных в AgentIDCard. Из кода убраны обработчики событий, методы и элементы интерфейса, связанные с номером, а также все компоненты NanoChat (как на клиентской, так и на серверной сторонах). Логика обновления состояния LogProbe упрощена, теперь передается только список логов. Также удалены строки локализации, прототипы, метаданные и ресурсы, относящиеся к NanoChat.

Changes

Файл(ы) Изменения
Content.Client/Access/UI/AgentIDCardBoundUserInterface.cs, AgentIDCardWindow.xaml, AgentIDCardWindow.xaml.cs Удаление обработки числового поля: удалены событие OnNumberChanged, метод SetCurrentNumber и связанные элементы управления.
Content.Client/CartridgeLoader/Cartridges/LogProbeUi.cs, LogProbeUiFragment.xaml, LogProbeUiFragment.xaml.cs Изменение логики обновления UI: передача только PulledLogs вместо полного состояния, упрощение обработки логов.
Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/* (NanoChatEntry, NanoChatLogEntry, NanoChatMessageBubble, NanoChatUi, NanoChatUiFragment, NewChatPopup) Полное удаление всех компонентов и логики NanoChat из клиентской части.
Content.Server/Access/Systems/AgentIDCardSystem.cs, LogProbeCartridgeComponent.cs, LogProbeCartridgeSystem.cs, LogProbeCartridgeSystem.NanoChat.cs, NanoChatCartridgeComponent.cs, NanoChatCartridgeSystem.cs, NanoChatSystem.cs Удаление поддержки NanoChat на сервере: удалены зависимости, инициализация и обработка событий, связанные с NanoChat.
Content.Shared/Access/SharedAgentIDCardSystem.cs, LogProbeUiState.cs, NanoChatUiMessageEvent.cs, NanoChatUiState.cs, NanoChatCardComponent.cs, SharedNanoChatSystem.cs Удаление всех NanoChat-сущностей, сообщений и структур из общей части проекта.
Resources/Locale/en-US/..., Resources/Locale/ru-RU/... Удаление или деактивация строк локализации, связанных с NanoChat и отображением номера в AgentIDCard.
Resources/Prototypes/Entities/Objects/Misc/identification_cards.yml, pda.yml, cartridges.yml, name_identifier_groups.yml Удаление компонентов NanoChat из прототипов, изменение настроек идентификационных карточек и PDA.
Resources/Locale/ru-RU/backmen/disease/*.ftl Корректировка комментариев и активация строк для локализации заболеваний (раскомментированы строки в swab.ftl).

Sequence Diagram(s)

sequenceDiagram
    participant Пользователь as User
    participant LP as LogProbeUi
    participant Фрагмент as LogProbeUiFragment

    Пользователь->>LP: Инициирует обновление UI
    LP->>Фрагмент: Вызывает UpdateState с PulledLogs
    Фрагмент->>Фрагмент: Обработка и отображение логов
    Фрагмент->>Пользователь: Отображение обновленных логов
Loading

Poem

Я кролик, веселый и быстрый,
В ушах весна, в коде порядок,
NanoChat ушёл, как осенний лист,
Осталась чистота, как в поле морщ,
Прыгаю радостно – жизнь летит вперёд!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3374c63 and 9237ec3.

⛔ Files ignored due to path filters (5)
  • Resources/Textures/_CorvaxNext/Interface/VerbIcons/bell.svg is excluded by !**/*.svg
  • Resources/Textures/_CorvaxNext/Interface/VerbIcons/bell.svg.png is excluded by !**/*.png
  • Resources/Textures/_CorvaxNext/Interface/VerbIcons/bell_muted.png is excluded by !**/*.png
  • Resources/Textures/_CorvaxNext/Misc/program_icons.rsi/nanochat.png is excluded by !**/*.png
  • Resources/Textures/_CorvaxNext/Objects/Devices/cartridge.rsi/cart-chat.png is excluded by !**/*.png
📒 Files selected for processing (46)
  • Content.Client/Access/UI/AgentIDCardBoundUserInterface.cs (0 hunks)
  • Content.Client/Access/UI/AgentIDCardWindow.xaml (0 hunks)
  • Content.Client/Access/UI/AgentIDCardWindow.xaml.cs (0 hunks)
  • Content.Client/CartridgeLoader/Cartridges/LogProbeUi.cs (1 hunks)
  • Content.Client/CartridgeLoader/Cartridges/LogProbeUiFragment.xaml (1 hunks)
  • Content.Client/CartridgeLoader/Cartridges/LogProbeUiFragment.xaml.cs (2 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatEntry.xaml (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatEntry.xaml.cs (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatLogEntry.xaml (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatLogEntry.xaml.cs (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatMessageBubble.xaml (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatMessageBubble.xaml.cs (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatUi.cs (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatUiFragment.xaml (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatUiFragment.xaml.cs (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NewChatPopup.xaml (0 hunks)
  • Content.Client/_CorvaxNext/CartridgeLoader/Cartridges/NewChatPopup.xaml.cs (0 hunks)
  • Content.Client/_CorvaxNext/NanoChat/NanoChatSystem.cs (0 hunks)
  • Content.Server/Access/Systems/AgentIDCardSystem.cs (1 hunks)
  • Content.Server/CartridgeLoader/Cartridges/LogProbeCartridgeComponent.cs (0 hunks)
  • Content.Server/CartridgeLoader/Cartridges/LogProbeCartridgeSystem.cs (2 hunks)
  • Content.Server/_CorvaxNext/CartridgeLoader/Cartridges/LogProbeCartridgeSystem.NanoChat.cs (0 hunks)
  • Content.Server/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatCartridgeComponent.cs (0 hunks)
  • Content.Server/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatCartridgeSystem.cs (0 hunks)
  • Content.Server/_CorvaxNext/NanoChat/NanoChatSystem.cs (0 hunks)
  • Content.Shared/Access/SharedAgentIDCardSystem.cs (1 hunks)
  • Content.Shared/CartridgeLoader/Cartridges/LogProbeUiState.cs (2 hunks)
  • Content.Shared/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatUiMessageEvent.cs (0 hunks)
  • Content.Shared/_CorvaxNext/CartridgeLoader/Cartridges/NanoChatUiState.cs (0 hunks)
  • Content.Shared/_CorvaxNext/NanoChat/NanoChatCardComponent.cs (0 hunks)
  • Content.Shared/_CorvaxNext/NanoChat/SharedNanoChatSystem.cs (0 hunks)
  • Resources/Locale/en-US/_corvaxnext/access/components/agent-id-card-component.ftl (0 hunks)
  • Resources/Locale/en-US/_corvaxnext/cartridge-loader/nanochat.ftl (0 hunks)
  • Resources/Locale/en-US/_corvaxnext/nanochat/components/nanochat-card-component.ftl (0 hunks)
  • Resources/Locale/ru-RU/_corvaxnext/access/components/agent-id-card-component.ftl (0 hunks)
  • Resources/Locale/ru-RU/_corvaxnext/cartridge-loader/nanochat.ftl (0 hunks)
  • Resources/Locale/ru-RU/_corvaxnext/nanochat/components/nanochat-card-component.ftl (0 hunks)
  • Resources/Locale/ru-RU/backmen/disease/disease.ftl (1 hunks)
  • Resources/Locale/ru-RU/backmen/disease/swab.ftl (1 hunks)
  • Resources/Prototypes/Entities/Objects/Devices/pda.yml (0 hunks)
  • Resources/Prototypes/Entities/Objects/Misc/identification_cards.yml (0 hunks)
  • Resources/Prototypes/_CorvaxNext/Entities/Objects/Devices/cartridges.yml (0 hunks)
  • Resources/Prototypes/_CorvaxNext/name_identifier_groups.yml (0 hunks)
  • Resources/Textures/_CorvaxNext/Interface/VerbIcons/ATTRIBUTION.txt (0 hunks)
  • Resources/Textures/_CorvaxNext/Misc/program_icons.rsi/meta.json (0 hunks)
  • Resources/Textures/_CorvaxNext/Objects/Devices/cartridge.rsi/meta.json (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Rxup Rxup merged commit f8b694a into master Feb 16, 2025
13 of 15 checks passed
@github-actions github-actions bot added size/L S: Untriaged Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation and removed S: Untriaged labels Feb 16, 2025
Copy link
Contributor

RSI Diff Bot; head commit 9237ec3 merging into 3374c63
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_CorvaxNext/Misc/program_icons.rsi

State Old New Status
nanochat Removed

Resources/Textures/_CorvaxNext/Objects/Devices/cartridge.rsi

State Old New Status
cart-chat Removed

@KayzelW KayzelW deleted the revert-1055-NanoChat branch February 20, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant