-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keccak pulling std features #86
Comments
That seems like a bug in the |
Yeah, |
I am also surprised Anyway, here's a PR to |
keccak crate still passes check on no_std targets e.g. |
@milosdjurica the |
In Cargo.lock , Keccak still points on v0.2.16 of |
Cargo.lock committed in this repository has not effect on |
As you can check, when running the following command, keccak includes std features via
cpufeatures
crate. It can cause problems later on for end users, in case they need fullyno_std
compatible library.Command ->
Output ->
I will open a PR with a fix to make
cpufeatures
optional dependency and make it be included by default. This way users get the feature by default, but they can also opt out of it, if they need/want to.The text was updated successfully, but these errors were encountered: