Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrypt: add PHC hash support using password-hash crate #111

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

tarcieri
Copy link
Member

Implements the PHC string format for hashes, gated under the simple cargo feature.

Specifics of how the format is encoded/decoded are modeled off of how passlib implements PHC scrypt hashes:

https://passlib.readthedocs.io/en/stable/lib/passlib.hash.scrypt.html

@tarcieri tarcieri requested a review from newpavlov January 29, 2021 20:15
@tarcieri tarcieri force-pushed the scrypt/phc-string-format branch 3 times, most recently from 21fdfd5 to da7749e Compare January 29, 2021 20:48
@tarcieri tarcieri force-pushed the scrypt/phc-string-format branch from da7749e to eb9fa73 Compare January 29, 2021 20:50
@tarcieri tarcieri marked this pull request as ready for review January 29, 2021 20:51
@tarcieri tarcieri changed the title [WIP] scrypt: add PHC hash support using password-hash crate scrypt: add PHC hash support using password-hash crate Jan 29, 2021
scrypt/src/lib.rs Outdated Show resolved Hide resolved
pub struct ScryptParams {
pub(crate) log_n: u8,
pub(crate) r: u32,
pub(crate) p: u32,
pub(crate) len: usize,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcieri tarcieri force-pushed the scrypt/phc-string-format branch 3 times, most recently from 7e614f1 to b766f96 Compare January 29, 2021 21:17
Implements the PHC string format for hashes, gated under the `simple`
cargo feature.

Specifics of how the format is encoded/decoded are modeled off of how
passlib implements PHC scrypt hashes:

https://passlib.readthedocs.io/en/stable/lib/passlib.hash.scrypt.html
@tarcieri tarcieri force-pushed the scrypt/phc-string-format branch from b766f96 to 8fce0f2 Compare January 29, 2021 21:19
@tarcieri tarcieri merged commit 1160c5e into master Jan 29, 2021
@tarcieri tarcieri deleted the scrypt/phc-string-format branch January 29, 2021 21:22
@tarcieri tarcieri mentioned this pull request Jan 29, 2021
dns2utf8 pushed a commit to dns2utf8/password-hashes that referenced this pull request Jan 24, 2023
crypto-mac/digest: rename `input` to `update`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant