Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aes: compilation errors on cg_clif due to lack of intrinsics support #391

Closed
tarcieri opened this issue Nov 8, 2023 · 4 comments
Closed

Comments

@tarcieri
Copy link
Member

tarcieri commented Nov 8, 2023

See:

Cranelift doesn't support these intrinsics yet, so compilation fails it inserts traps instead of using the intrinsics.

I've suggested cfg(aes_force_soft) as a workaround, but it would be nice if this just worked, and even better if hardware acceleration worked.

One option would be to use inline assembly, which would also provide an avenue to address #385.

@tarcieri
Copy link
Member Author

tarcieri commented Nov 8, 2023

cc @bjorn3

@newpavlov
Copy link
Member

It's clearly a Cranelift issue and I don't think we should do anything to address it.

@AppleSheeple
Copy link

AppleSheeple commented Nov 9, 2023

Cranelift doesn't support these intrinsics yet, so compilation fails.

For the sake of accuracy, missing intrinsics trigger warnings about traps used instead of unimplemented intrinsics. Compilation does not fail!

@tarcieri
Copy link
Member Author

Looks like this will be addressed by rust-lang/rustc_codegen_cranelift#1425

Going to go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants