Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode visual problems #57

Open
bjones1 opened this issue Jul 30, 2021 · 1 comment
Open

Dark mode visual problems #57

bjones1 opened this issue Jul 30, 2021 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@bjones1
Copy link
Contributor

bjones1 commented Jul 30, 2021

Dark mode still has a number of visual rendering problems -- fixing this will probably require a serious deep dive in the CSS in runestone/accessibility/css. In particular, the text in a HTML class sidebar (generated by a .. sidebar:: directive) is unreadable. Text in a .. code-block directive (which translate to an HTML class code) is still in light mode.

image
@bnmnetp bnmnetp added bug Something isn't working help wanted Extra attention is needed labels Jul 30, 2021
@campbelle2
Copy link

Working on this

campbelle2 referenced this issue in campbelle2/RunestoneComponents Aug 5, 2022
@campbelle2
Merge branch 'master' into issue-#1235
85443b3
@campbelle2 campbelle2 mentioned this issue Aug 5, 2022
Open
bnmnetp referenced this issue in campbelle2/RunestoneComponents Aug 19, 2022
@bnmnetp
Merge branch 'master' into issue-#1235
451cc6b
@bnmnetp bnmnetp transferred this issue from RunestoneInteractive/RunestoneComponents Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bnmnetp @bjones1 @campbelle2