Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Auto load history for activecode problems on page load #1362

Conversation

ascholerChemeketa
Copy link
Contributor

Remove "Load History" button completely
Load historyscrubber on activecode problem initialization

Remove "Load History" button completely
Load historyscrubber on activecode problem initialization
@ascholerChemeketa
Copy link
Contributor Author

Proposed changes for experiment with automatically loading history for activecode problems.

@bnmnetp
Copy link
Member

bnmnetp commented Sep 8, 2022

This looks good except for in a timed exam. Yeah welcome to my world -- timed exams have always been problematic. In a timed exam we show the slider from the start. Now we are getting double sliders.

Screen Shot 2022-09-08 at 4 56 46 PM

@bnmnetp
Copy link
Member

bnmnetp commented Sep 8, 2022

The overview book has a couple of timed exams you can play with.

@bnmnetp
Copy link
Member

bnmnetp commented Sep 8, 2022

I see ---

See the timedInit function in TimedActiveCodeMixin where I already have the call await this.addHistoryScrubber(true);

@bnmnetp
Copy link
Member

bnmnetp commented Sep 8, 2022

No need for you to do anything... I just removed that call and everything looks good.

I don't think there is any reason to worry about awaiting it when we load the page and are initializing everything. I think I was just doing that for timed exams to be careful.

@bnmnetp bnmnetp merged commit bf0d3a3 into RunestoneInteractive:master Sep 8, 2022
@bnmnetp
Copy link
Member

bnmnetp commented Sep 8, 2022

OK, this will be live on Saturday. We will know a lot by Monday morning.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants