This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Dropdown menu fixes #1361
Merged
Dropdown menu fixes #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for Brad - adding one more fix to the dark/light slider... still in progress. |
Fix accessibility by moving "Dark Mode" text inside label element Cleanup layout - change size and indent to match other elements; add hover color to indicate interactivity
|
Added the Dark Mode fix. Think this is done now. |
|
Thanks, I will get it reviewed in the next day or two. |
|
Thanks! the dark mode toggle looks much nicer! I knew there had to be a way to do that. I had not noticed that the search was broken either. I copied that change to the server code so its fixed there now too... Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two minor but visually annoying layout issues in top of page dropdowns.
Padding of items inside social menu ("Runestone in social media", "Help support us", and Donate button)
Display of search button next to text input inside search menu