-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-update demo screenshot in README #9
Comments
Interesting problem, I will experiment on my own repos to try to achieve this result |
How exactly is this supposed to work? |
tldr
|
To deploy changes to the cra package automatically:
I would be happy to help build this out, but I don't have access to Rubric's Vercel deployment/config |
@iamshanvy and @arihanv Thanks for laying out a path to accomplish this. I agree with the proposed implementation - a puppeteer generated - static image url - triggered by action is elegant. I think @tedspare deployed the template from this repo to create-rubric-app.vercel.app. Not sure how that works - but I don't think the DB is currently functional. Either way - the hardest part of this seems to be the screenshot. I can set up the Vercel config in the account if anyone manages to get something working with puppeteer. This would be really cool - but no pressure, it's very much a nice to have and not blocking the core product. |
Yep I deployed the template directly to Vercel and it's blocked by the Prisma DB provider being SQLite. If we could make the DB provider dynamic (no longer supported), it could be set in .env.local as Another approach is SQLite in prod (fine for a demo imo). This requires a persistent filesystem unlike serverless. I think we're close, open to ideas ๐ |
Super cool idea that could be useful or a whole range of uses! Eg. link preview images, blog previews. |
Hey! In order to fix DB issues and to have easier deployments, I propose using Vercel KV. It's commonly used by vercel ai services to store JSON data which is exactly what we have. This will go hand in hand with the Vercel deployment and is easy to configure |
Hey @DexterStorey! I wrote some puppeteer code to generate a screenshot and it works well. I think we can make it even easier and just save the screenshot to a path (it does that by default) within the Github repo, and then dynamically change the image reference in the readme to refer to the screenshot or we can go with my previously proposed implementation. Let me know what you want me to do with the code. |
Good point - I think vercel postgres would be even easier. |
this is the way. Env the db type. |
In this case we would commit the image every time? I think the code would probably go in the root in like a utils folder and be called by a GitHub action workflow in .github/workflows? |
Yeah, I think the image would go in like a "public" or "assets" folder in the repo. Also, instead of Prisma, we should be using Drizzle ORM. It's much more performant and is kind of industry standard now, but this is not that important to change right now. |
hop on gather -> island.rubriclabs.com |
Yeah, I believe it would need to be a github action. Here is a reference from the Supabase GitHub. They use this action to automatically create embeddings of their docs once a change to their docs is pushed. https://github.com/supabase/supabase/blob/master/.github/workflows/search.yml |
I agree. what do you think of using vercel postgres as the default db provider. I feel like the more we integrate with Vercel, the easier it is to deploy. |
Will hop on in about two hours if y'all are still gonna be there. |
I will leave this issue, it seems that @arihanv can take care of it ๐ช
need to be careful with the cost though
debatable
just in case later, check out this tool, puppeteer in pipeline might slowdown builds (guessing)? sorry for being an old man ๐ |
It would be really cool if changes to the cra package automatically:
๐ฎโ๐จ
The text was updated successfully, but these errors were encountered: