Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saner TypeTranslation() in Kernel/System/DB/mysql.pm #1169

Open
bschmalhofer opened this issue Aug 10, 2021 · 0 comments
Open

Saner TypeTranslation() in Kernel/System/DB/mysql.pm #1169

bschmalhofer opened this issue Aug 10, 2021 · 0 comments
Assignees
Milestone

Comments

@bschmalhofer
Copy link
Contributor

_TypeTranslation() in mysql.pm is in principle broken. When e.g. VARCHAR(60_000) is declared, then it would be mapped into a TEXT. But 60_000 4-Byte characters do not fit into a TEXT field. In practice it's not really relevant, the largest TEXT fleld requires bytes that accomodate 10_000 characters. For the longest MEDIUMTEXT field its 1_800_000 characters. There is no conflict.

For postgresql.pm everything is fine. All columns declared as VARCHAR in otobo-schema.xml are either mapped into the appropriate VARCHAR(n) type or mapped into VARCHAR. And VARCHAR has no size restriction in PostgreSQL.

So, I propose to fix _TypeTranslation() in Kernel/System/DB/mysql,pm , causing no changes when the present otobo-schema.xml is used

Originally posted by @bschmalhofer in #1166 (comment)

@bschmalhofer bschmalhofer self-assigned this Aug 10, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Aug 10, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 11.0 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant