Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is frame_missing_handler.js still relevant? #119

Open
reedrolemodel opened this issue May 2, 2024 · 1 comment
Open

Is frame_missing_handler.js still relevant? #119

reedrolemodel opened this issue May 2, 2024 · 1 comment

Comments

@reedrolemodel
Copy link
Member

reedrolemodel commented May 2, 2024

frame_missing_handler.js refers to a merged issue.

@OutlawAndy
Copy link
Member

@reedrolemodel Yes, it is. Though that comment may be less relevant than it used to be.. Our existing Modal/Panel pattern still relies on a global turbo:frame-missing handler as an escape hatch after a successful form-submission redirect.

I've experimented with a number of patterns here and weighing the various trade-offs, I still believe this is the best "general" solution. Especially considering that this handler also serves to enable Turbo 8 morphing + scroll preservation in the case that you're redirecting back to the page which originally opened the modal/panel, as that negates a whole host of custom turbo-stream use-cases and is otherwise not possible via Turbo alone.

I'm happy to discuss alternatives on a call if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants