No info given to new OAuth users that need manual approval

[torgeirl]

Description:

With Accounts > Registration > Manually Approve New Users = True, new users signing up using a custom OAuth providers are thrown back to the login screen. They are not given any instructions or other indication that that login will not be available before the account is activated by an administrator. To the user, it looks like a glitch.

Server Setup Information:

• Version of Rocket.Chat Server: 0.60

Steps to Reproduce:

1. Set Accounts > Registration > Manually Approve New Users = True
2. Under OAuth, setup a custom Oauth provider
3. Try login in with (test) user from that provider

Expected behavior:

Some page / popup after returning from the OAuth provider informing the user that login not will be available before the account is activated by an administrator.

Actual behavior:

After returning form the OAuth provider, the user is just thrown to the login screen.

Similar issues:

#9063 points out the info for new users that need manually approval is misleading, but new custom OAuth users aren't provided any information so I assume the issues aren't related and needs to be solved differently.

[mch1307]

Looks like it's not fixed in 3.13.2. For local accounts, proper "registration succeeded" message is showed, but oauth users are thrown to the login screen without meaningful message