Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [UI] Attachment icons alignment is incorrect #8183

Closed
cyclops24 opened this issue Sep 18, 2017 · 5 comments · Fixed by #8271
Closed

[BUG] [UI] Attachment icons alignment is incorrect #8183

cyclops24 opened this issue Sep 18, 2017 · 5 comments · Fixed by #8271
Assignees
@ggazzo
Milestone
0.59.0-rc.9

Comments

@cyclops24
Copy link
Contributor

Hey guys,
I found this bug in a chat with @ggazzo I think @karlprieb can join us here to solve this.
It's incorrect alignment in RTL mode (Arabic):
06
And it's correct alignment in LTR mode (English):
6 1
@cyclops24 cyclops24 mentioned this issue Sep 18, 2017
Closed
4 tasks
@cyclops24
Copy link
Contributor Author

cyclops24 commented Sep 19, 2017 •
edited
Loading

It's also not align in LTR (English) Below image contain rulers for more info:
03

@MartinSchoeler please label this as a bug 😉

@cyclops24 cyclops24 changed the title [BUG] [UI] Attachment icons alignment is incorrect in RTL [BUG] [UI] Attachment icons alignment is incorrect Sep 19, 2017
@rodrigok rodrigok added this to the 0.59.0-rc.8 milestone Sep 22, 2017
@gdelavald gdelavald modified the milestones: 0.59.0-rc.8, 0.60.0 Sep 22, 2017
@engelgabriel engelgabriel modified the milestones: 0.60.0, 0.59.0-rc.9 Sep 23, 2017
@engelgabriel
Copy link
Member

@gdelavald this needs to be fixed before the release of the version 0.59.0

@engelgabriel
Copy link
Member

Part of #8175

@cyclops24 cyclops24 mentioned this issue Sep 23, 2017
Merged
@cyclops24
Copy link
Contributor Author

@engelgabriel I done it. Please see #8271

@engelgabriel
Copy link
Member

thanks @cyclops24 I'll merge it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggazzo ggazzo

Labels
None yet
Projects
None yet
Milestone
0.59.0-rc.9
Development

Successfully merging a pull request may close this issue.

[FIX] Attachment icons alignment in LTR and RTL
5 participants
@rodrigok @engelgabriel @ggazzo @gdelavald @cyclops24