Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a user mention on a direct message should enable you to open a new direct message with that user #11007

Closed
marceloschmidt opened this issue Jun 5, 2018 · 2 comments · Fixed by #11050

Comments

@marceloschmidt
Copy link
Member

Description:

If I'm on a direct message and click on a user mention @username the User Info show up, but there's no button to open a direct message with that user. If you do the same on a channel or private group, it enables you to create a direct message with the user.

The current implementation checks if room type is direct message, then hides the button, assuming user is viewing the current DM's user info. It should check if the user info refers to the current user or some other mentioned user.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.65.1

Steps to Reproduce:

  1. Open a direct message with someone
  2. Mention someone else
  3. Click on the mentioned user; user info shows up on the right
  4. There's no "Conversation" button to start a new direct message

Expected behavior:

I'd like to see a "Conversation" button to start a new direct message with the mentioned user

Screenshots:

When clicking from within a channel:

image

When clicking from within a direct message:

image

@fundrequestbot
Copy link


This issue has been funded using FundRequest. A developer can claim the reward by submitting a pull request referencing this issue. (How to Close Issues via Pull Requests?) e.g. fixes #11007

  • For more help on how to claim on issue, please visit our help section.
  • Looking for more? Feel free to browse through all funded requests.

@fundrequestbot
Copy link

fundrequestbot commented Jun 13, 2018


Thank you @ggazzo for your code contribution. The reward linked to this issue has been transferred to your account.

  • Looking for more? Feel free to browse through all funded requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants