Skip to content
This repository has been archived by the owner on Mar 13, 2019. It is now read-only.

Add support for php7 #29

Closed
agiuliano opened this issue Dec 3, 2015 · 8 comments
Closed

Add support for php7 #29

agiuliano opened this issue Dec 3, 2015 · 8 comments

Comments

@agiuliano
Copy link

Php 7 is going to be released, why not to add a branch with php7 under the hood?

@RobLoach
Copy link
Owner

RobLoach commented Dec 3, 2015

https://hub.docker.com/r/library/php/

Looks like targeting 7-cli will bring in PHP 7.0.0-RC8 currently. Sounds like a great plan.

@RobLoach RobLoach mentioned this issue Dec 3, 2015
@agiuliano
Copy link
Author

@RobLoach is it normal that if I enter in the downloaded composer/composer:php7 and I type php --version it says PHP 5.6.15 (cli)?

@RobLoach
Copy link
Owner

RobLoach commented Dec 7, 2015

@agiuliano It's because php7 uses composer/composer:base, which is currently tagged as using PHP 5.6 😉 . We'll need a composer/composer:php7-base, or something.

@agiuliano
Copy link
Author

but in composer/composer:base I see that php-7 is required in the php7 branch (https://github.com/RobLoach/docker-composer/blob/php7/base/Dockerfile)

@RobLoach
Copy link
Owner

RobLoach commented Dec 7, 2015

True, but composer/composer:base is tagged on Docker Hub with php 5.6. We'll need to modify the branch to use a different base.

Like this: 43fa55f

@agiuliano
Copy link
Author

you're right, do you already tagged the php7-base on dockerhub to the php7 branch?

@RobLoach
Copy link
Owner

RobLoach commented Dec 8, 2015

composer/composer:php7 should be up by now.

@RobLoach
Copy link
Owner

RobLoach commented Apr 6, 2016

Now that PHP 7.0.5 is out, and considered stable. I'm proposing we switch composer/composer:base to target php:cli.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants