Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven modules discovery logs #272

Closed
Riduidel opened this issue Oct 11, 2022 · 0 comments
Closed

Add maven modules discovery logs #272

Riduidel opened this issue Oct 11, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers.

Comments

@Riduidel
Copy link
Owner

Riduidel commented Oct 11, 2022

Currently, the aadarchi GenerateDiagramsMojo task invokes MavenDetailInfererEnhancer, which discovers submodules. But if it doesn't, no error is output.

THe optimal behaviour would be at each endVisit to have a log message emitted counting the number of added elements.

For that, we need

  1. @Inject Logger logger in variables
  2. In each startVisit method, store in a property the element the number of children (something like aadarchi.internal.MavenDetailInfererEnhancer.children.count)
  3. In each endVisit method, remove the property storing the number of children, remove this number from the current number of children.
  4. If the remaining is >0, output a log message
@Riduidel Riduidel added enhancement good first issue Good for newcomers. labels Oct 11, 2022
@Se-C12 Se-C12 self-assigned this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

2 participants