Duplicate Game Finder/Cleaner for Steam libraries (#63 - #73)

Author: RevoLand

Binaries/Steam Library Manager.exe

@@ -6,22 +6,24 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 ## [Unreleased]
 
-## [1.5.1.11] - 2019-07-25
+## [1.5.1.11] - 2019-08-02
 
 ### Added
 
 - Ability to continue on error for task manager tasks (#68)
 - Ability to skip restart warning for Steam library related tasks (#69)
 - Icons! [(Have a sneak-peek)](https://dl.dropboxusercontent.com/s/e9ruwj4f11yg5pn/21-Sunday-vB67mD7A1020.gif)
 - Ability to Compress Origin games
-  - And 'Auto Install' for Origin related tasks
+- And ability to 'Auto Install' for Origin tasks
 - HamburgerMenu Addition to Library Panel for library type switching (#71)
+- Duplicate Game Finder/Cleaner for Steam libraries ([#73](https://github.com/RevoLand/Steam-Library-Manager/issues/73))
 
 ### Changed
 
 - Library Creation dialog is replaced with a flyout panel which clears the path for supporting more library types. (#63 #65)
 - Unified Task Manager's List View for Steam & Origin games for easier editing in future.
 - Tweaked Task Manager UI a little bit
+- Library Cleaner ui improved
 
 ### Fixed
 

CHANGELOG.md

@@ -1,6 +1,7 @@
 using MahApps.Metro;
 using System;
 using System.Windows;
+using System.Windows.Threading;
 
 namespace Steam_Library_Manager
 {
@@ -18,6 +19,8 @@ protected override void OnStartup(StartupEventArgs e)
                                             ThemeManager.GetAppTheme(Steam_Library_Manager.Properties.Settings.Default.BaseTheme));
 
                 base.OnStartup(e);
+
+                Dispatcher.UnhandledException += OnDispatcherUnhandledException;
             }
             catch (UnauthorizedAccessException ex)
             {
@@ -29,5 +32,14 @@ protected override void OnStartup(StartupEventArgs e)
                 MessageBox.Show(ex.ToString());
             }
         }
+
+        private void OnDispatcherUnhandledException(object sender, DispatcherUnhandledExceptionEventArgs e)
+        {
+            string errorMessage = $"An unhandled exception occurred: {e.Exception.Message}";
+            MessageBox.Show(errorMessage, "Error", MessageBoxButton.OK, MessageBoxImage.Error);
+            // OR whatever you want like logging etc. MessageBox it's just example
+            // for quick debugging etc.
+            e.Handled = true;
+        }
     }
 }

Source/Steam Library Manager/App.xaml.cs

@@ -587,11 +587,11 @@ await Main.FormAccessor.AppView.AppPanel.Dispatcher.Invoke(async delegate
                             currentTask.Active = false;
                             currentTask.Completed = true;
 
-                            _ = Main.FormAccessor.AppView.AppPanel.Dispatcher.Invoke(async delegate
+                            Main.FormAccessor.AppView.AppPanel.Dispatcher.Invoke(async delegate
                               {
-                                  if (await Main.FormAccessor.ShowMessageAsync(Functions.SLM.Translate(nameof(Properties.Resources.RemoveMovedFiles)), Framework.StringFormat.Format(Functions.SLM.Translate(nameof(Properties.Resources.PathTooLongException)), new { AppName, ExceptionMessage = ex.Message }), MessageDialogStyle.AffirmativeAndNegative).ConfigureAwait(false) == MessageDialogResult.Affirmative)
+                                  if (await Main.FormAccessor.ShowMessageAsync(Functions.SLM.Translate(nameof(Properties.Resources.RemoveMovedFiles)), Framework.StringFormat.Format(Functions.SLM.Translate(nameof(Properties.Resources.PathTooLongException)), new { AppName, ExceptionMessage = ex.Message }), MessageDialogStyle.AffirmativeAndNegative).ConfigureAwait(true) == MessageDialogResult.Affirmative)
                                   {
-                                      Functions.FileSystem.RemoveGivenFilesAsync(copiedFiles, createdDirectories, currentTask);
+                                      await Functions.FileSystem.RemoveGivenFilesAsync(copiedFiles, createdDirectories, currentTask);
                                   }
                               }, System.Windows.Threading.DispatcherPriority.Normal);
 
@@ -610,7 +610,7 @@ await Main.FormAccessor.AppView.AppPanel.Dispatcher.Invoke(async delegate
 
                             Main.FormAccessor.AppView.AppPanel.Dispatcher.Invoke(async delegate
                             {
-                                if (await Main.FormAccessor.ShowMessageAsync(Functions.SLM.Translate(nameof(Properties.Resources.RemoveMovedFiles)), Framework.StringFormat.Format(Functions.SLM.Translate(nameof(Properties.Resources.FileSystemRelatedError_DeleteMovedFiles)), new { AppName, ExceptionMessage = ex.Message }), MessageDialogStyle.AffirmativeAndNegative).ConfigureAwait(false) == MessageDialogResult.Affirmative)
+                                if (await Main.FormAccessor.ShowMessageAsync(Functions.SLM.Translate(nameof(Properties.Resources.RemoveMovedFiles)), Framework.StringFormat.Format(Functions.SLM.Translate(nameof(Properties.Resources.FileSystemRelatedError_DeleteMovedFiles)), new { AppName, ExceptionMessage = ex.Message }), MessageDialogStyle.AffirmativeAndNegative).ConfigureAwait(true) == MessageDialogResult.Affirmative)
                                 {
                                     await Functions.FileSystem.RemoveGivenFilesAsync(copiedFiles, createdDirectories, currentTask);
                                 }
@@ -621,11 +621,11 @@ await Main.FormAccessor.AppView.AppPanel.Dispatcher.Invoke(async delegate
                         }
                         catch (UnauthorizedAccessException ex)
                         {
-                            _ = Main.FormAccessor.AppView.AppPanel.Dispatcher.Invoke(async delegate
+                            Main.FormAccessor.AppView.AppPanel.Dispatcher.Invoke(async delegate
                               {
-                                  if (await Main.FormAccessor.ShowMessageAsync(Functions.SLM.Translate(nameof(Properties.Resources.RemoveMovedFiles)), Framework.StringFormat.Format(Functions.SLM.Translate(nameof(Properties.Resources.FilePermissionRelatedError_DeleteFiles)), new { AppName, ExceptionMessage = ex.Message }), MessageDialogStyle.AffirmativeAndNegative).ConfigureAwait(false) == MessageDialogResult.Affirmative)
+                                  if (await Main.FormAccessor.ShowMessageAsync(Functions.SLM.Translate(nameof(Properties.Resources.RemoveMovedFiles)), Framework.StringFormat.Format(Functions.SLM.Translate(nameof(Properties.Resources.FilePermissionRelatedError_DeleteFiles)), new { AppName, ExceptionMessage = ex.Message }), MessageDialogStyle.AffirmativeAndNegative).ConfigureAwait(true) == MessageDialogResult.Affirmative)
                                   {
-                                      Functions.FileSystem.RemoveGivenFilesAsync(copiedFiles, createdDirectories, currentTask);
+                                      await Functions.FileSystem.RemoveGivenFilesAsync(copiedFiles, createdDirectories, currentTask);
                                   }
                               }, System.Windows.Threading.DispatcherPriority.Normal);
                         }
@@ -723,7 +723,7 @@ await Main.FormAccessor.AppView.AppPanel.Dispatcher.Invoke(async delegate
                     });
                 }
 
-            TaskEnd:
+                TaskEnd:
 
                 currentTask.ElapsedTime.Stop();
                 currentTask.MovedFileSize = totalFileSize;

Source/Steam Library Manager/Definitions/App.cs

@@ -74,13 +74,6 @@ public enum LibraryType
         SLM
     }
 
-    public enum GameType
-    {
-        Steam,
-        Origin,
-        Uplay
-    }
-
     [TypeConverter(typeof(EnumDescriptionTypeConverter))]
     public enum TaskType
     {
@@ -96,6 +89,15 @@ public enum TaskType
         Compact
     }
 
+    [TypeConverter(typeof(EnumDescriptionTypeConverter))]
+    public enum JunkType
+    {
+        HeadlessFolder,
+        HeadlessWorkshopFolder,
+        CorruptedDataFile,
+        HeadlessDataFile
+    }
+
     public enum ThemeAccents
     {
         Red,

Source/Steam Library Manager/Definitions/Enums/Enums.cs

@@ -23,7 +23,7 @@ public string FullPath
             set
             {
                 _fullPath = value;
-                Functions.FileSystem.DriveUsageStatistics(_fullPath, out var freeSpace, out var totalSpace, out var totalFreeSpace);
+                Functions.FileSystem.GetDiskFreeSpaceEx(_fullPath, out var freeSpace, out var totalSpace, out var totalFreeSpace);
 
                 FreeSpace = (long)freeSpace;
                 TotalSize = (long)totalSpace;
@@ -91,6 +91,8 @@ private List<FrameworkElement> GenerateCMenuItems()
 
         public abstract void UpdateJunks();
 
+        public abstract void UpdateDupes();
+
         public void UpdateDiskDetails()
         {
             OnPropertyChanged("DirectoryInfo");

Source/Steam Library Manager/Definitions/Library.cs

@@ -1,4 +1,5 @@
-using System;
+using Steam_Library_Manager.Definitions.Enums;
+using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.ComponentModel;
@@ -12,10 +13,12 @@ public static class List
         // Make a new list for Library details
         public static ObservableCollection<Library> Libraries { get; set; } = new ObservableCollection<Library>();
 
-        public static ObservableCollection<JunkInfo> LcItems { get; set; } = new ObservableCollection<JunkInfo>();
+        public static ObservableCollection<JunkInfo> JunkItems { get; set; } = new ObservableCollection<JunkInfo>();
+        public static ObservableCollection<DupeInfo> DupeItems { get; set; } = new ObservableCollection<DupeInfo>();
 
         public static readonly IProgress<Library> LibraryProgress = new Progress<Library>(library => Libraries.Add(library));
-        public static readonly IProgress<JunkInfo> LCProgress = new Progress<JunkInfo>(junk => LcItems.Add(junk));
+
+        public static readonly IProgress<JunkInfo> LCProgress = new Progress<JunkInfo>(junk => JunkItems.Add(junk));
 
         public static ObservableCollection<ContextMenuItem> LibraryCMenuItems { get; set; } = new ObservableCollection<ContextMenuItem>();
         public static ObservableCollection<ContextMenuItem> AppCMenuItems { get; set; } = new ObservableCollection<ContextMenuItem>();
@@ -96,9 +99,16 @@ public class JunkInfo
         {
             public System.IO.FileSystemInfo FSInfo { get; set; }
             public Library Library { get; set; }
-            public long Size { get; set; }
-            public string PrettyFolderSize => Functions.FileSystem.FormatBytes(Size);
-            public string JunkReason { get; set; }
+            public App App { get; set; }
+            public string Size { get; set; }
+            public JunkType Tag { get; set; }
+        }
+
+        public class DupeInfo
+        {
+            public App App1 { get; set; }
+            public App App2 { get; set; }
+            public string Size { get; set; }
         }
     }
 }

Source/Steam Library Manager/Definitions/List.cs

@@ -117,5 +117,10 @@ public override void UpdateJunks()
         {
             throw new NotImplementedException();
         }
+
+        public override void UpdateDupes()
+        {
+            throw new NotImplementedException();
+        }
     }
 }

Source/Steam Library Manager/Definitions/OriginLibrary.cs

@@ -1,4 +1,5 @@
 using MahApps.Metro.Controls.Dialogs;
+using Steam_Library_Manager.Definitions.Enums;
 using System;
 using System.Collections.Async;
 using System.Diagnostics;
@@ -72,12 +73,13 @@ public override async void UpdateAppListAsync()
                                 {
                                     return;
                                 }
+
                                 List.LCProgress.Report(new List.JunkInfo
                                 {
                                     FSInfo = new FileInfo(acfFile.FullName),
-                                    Size = acfFile.Length,
+                                    Size = Functions.FileSystem.FormatBytes(acfFile.Length),
                                     Library = this,
-                                    JunkReason = Functions.SLM.Translate(nameof(Properties.Resources.CorruptedAcfFile))
+                                    Tag = JunkType.CorruptedDataFile
                                 });
 
                                 return;
@@ -95,7 +97,7 @@ await Directory.EnumerateFiles(DirectoryList["SteamApps"].FullName, "*.zip", Sea
                     .ParallelForEachAsync(async archive => { await Task.Run(() => Functions.App.ReadDetailsFromZip(archive, this)).ConfigureAwait(false); }).ConfigureAwait(false);
 
                 DirectoryList["SteamBackups"].Refresh();
-                if (Type == Enums.LibraryType.SLM && DirectoryList["SteamBackups"].Exists)
+                if (Type == LibraryType.SLM && DirectoryList["SteamBackups"].Exists)
                 {
                     await DirectoryList["SteamBackups"].EnumerateFiles("*.sis", SearchOption.AllDirectories).ParallelForEachAsync(
                         async skuFile =>
@@ -301,38 +303,37 @@ public override async void RemoveLibraryAsync(bool withFiles)
 
                 List.Libraries.Remove(this);
 
-                if (Type == Enums.LibraryType.Steam)
-                {
-                    await Functions.Steam.CloseSteamAsync().ConfigureAwait(true);
+                if (Type != LibraryType.Steam) return;
 
-                    // Make a KeyValue reader
-                    var keyValReader = new Framework.KeyValue();
+                await Functions.Steam.CloseSteamAsync().ConfigureAwait(true);
 
-                    // Read vdf file
-                    keyValReader.ReadFileAsText(Global.Steam.VdfFilePath);
+                // Make a KeyValue reader
+                var keyValReader = new Framework.KeyValue();
 
-                    // Remove old library
-                    keyValReader["Software"]["Valve"]["Steam"].Children.RemoveAll(x => x.Value == FullPath);
+                // Read vdf file
+                keyValReader.ReadFileAsText(Global.Steam.VdfFilePath);
 
-                    var i = 1;
-                    foreach (var key in keyValReader["Software"]["Valve"]["Steam"].Children.FindAll(x => x.Name.Contains("BaseInstallFolder")))
-                    {
-                        key.Name = $"BaseInstallFolder_{i}";
-                        i++;
-                    }
+                // Remove old library
+                keyValReader["Software"]["Valve"]["Steam"].Children.RemoveAll(x => x.Value == FullPath);
 
-                    // Update libraryFolders.vdf file with changes
-                    keyValReader.SaveToFile(Global.Steam.VdfFilePath, false);
+                var i = 1;
+                foreach (var key in keyValReader["Software"]["Valve"]["Steam"].Children.FindAll(x => x.Name.Contains("BaseInstallFolder")))
+                {
+                    key.Name = $"BaseInstallFolder_{i}";
+                    i++;
+                }
 
-                    // Since this file started to interrupt us?
-                    // No need to bother with it since config.vdf is the real deal, just remove it and Steam client will handle with some magic.
-                    if (File.Exists(Path.Combine(Properties.Settings.Default.steamInstallationPath, "steamapps", "libraryfolders.vdf")))
-                    {
-                        File.Delete(Path.Combine(Properties.Settings.Default.steamInstallationPath, "steamapps", "libraryfolders.vdf"));
-                    }
+                // Update libraryFolders.vdf file with changes
+                keyValReader.SaveToFile(Global.Steam.VdfFilePath, false);
 
-                    Functions.Steam.RestartSteamAsync();
+                // Since this file started to interrupt us?
+                // No need to bother with it since config.vdf is the real deal, just remove it and Steam client will handle with some magic.
+                if (File.Exists(Path.Combine(Properties.Settings.Default.steamInstallationPath, "steamapps", "libraryfolders.vdf")))
+                {
+                    File.Delete(Path.Combine(Properties.Settings.Default.steamInstallationPath, "steamapps", "libraryfolders.vdf"));
                 }
+
+                Functions.Steam.RestartSteamAsync();
             }
             catch (Exception ex)
             {
@@ -364,12 +365,12 @@ public override void UpdateJunks()
                         var junk = new List.JunkInfo
                         {
                             FSInfo = dirInfo,
-                            Size = Functions.FileSystem.GetDirectorySize(dirInfo, true),
+                            Size = Functions.FileSystem.FormatBytes(Functions.FileSystem.GetDirectorySize(dirInfo, true)),
                             Library = this,
-                            JunkReason = Functions.SLM.Translate(nameof(Properties.Resources.HeadlessFolderNoCorrespondingAcfFile))
+                            Tag = JunkType.HeadlessFolder
                         };
 
-                        if (List.LcItems.Count(x => x.FSInfo.FullName == junk.FSInfo.FullName) == 0)
+                        if (List.JunkItems.Count(x => x.FSInfo.FullName == junk.FSInfo.FullName) == 0)
                         {
                             if (Properties.Settings.Default.IgnoredJunks != null &&
                                 Properties.Settings.Default.IgnoredJunks.Contains(dirInfo.FullName))
@@ -394,12 +395,12 @@ public override void UpdateJunks()
                             var junk = new List.JunkInfo
                             {
                                 FSInfo = fileDetails,
-                                Size = fileDetails.Length,
+                                Size = Functions.FileSystem.FormatBytes(fileDetails.Length),
                                 Library = this,
-                                JunkReason = Functions.SLM.Translate(nameof(Properties.Resources.HeadlessFileNoCorrespondingİnstallation))
+                                Tag = JunkType.HeadlessWorkshopFolder
                             };
 
-                            if (List.LcItems.Count(x => x.FSInfo.FullName == junk.FSInfo.FullName) == 0)
+                            if (List.JunkItems.Count(x => x.FSInfo.FullName == junk.FSInfo.FullName) == 0)
                             {
                                 if (Properties.Settings.Default.IgnoredJunks != null &&
                                     Properties.Settings.Default.IgnoredJunks.Contains(fileDetails.FullName))
@@ -417,5 +418,39 @@ public override void UpdateJunks()
                 Logger.Fatal(ex);
             }
         }
+
+        public override void UpdateDupes()
+        {
+            try
+            {
+                while (IsUpdatingAppList)
+                {
+                    Task.Delay(5000);
+                }
+
+                foreach (var library in List.Libraries.Where(x => x.Type == LibraryType.Steam && x != this))
+                {
+                    foreach (var targetApp in library.Apps.Where(x => !x.IsCompressed))
+                    {
+                        foreach (var currentApp in Apps.Where(x => !x.IsCompressed && x.AppId == targetApp.AppId))
+                        {
+                            if (List.DupeItems.Count(x => x.App1 == targetApp || x.App2 == targetApp) == 0)
+                            {
+                                List.DupeItems.Add(new List.DupeInfo()
+                                {
+                                    App1 = currentApp,
+                                    App2 = targetApp,
+                                    Size = targetApp.PrettyGameSize,
+                                });
+                            }
+                        }
+                    }
+                }
+            }
+            catch (Exception ex)
+            {
+                Logger.Fatal(ex);
+            }
+        }
     }
 }

Source/Steam Library Manager/Definitions/SteamLibrary.cs

@@ -99,5 +99,10 @@ public override void UpdateJunks()
         {
             throw new NotImplementedException();
         }
+
+        public override void UpdateDupes()
+        {
+            throw new NotImplementedException();
+        }
     }
 }