Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Rollup for building vue-highlighter #26

Open
Remeic opened this issue Oct 3, 2020 · 1 comment · May be fixed by #28
Open

Using Rollup for building vue-highlighter #26

Remeic opened this issue Oct 3, 2020 · 1 comment · May be fixed by #28
Assignees
@khamer
Labels
good first issue Good for newcomers hacktoberfest label for hacktoberfest event help wanted Extra attention is needed

Comments

@Remeic
Copy link
Owner

Remeic commented Oct 3, 2020

Hi, we need to migrate to rollup instead of bili.
A good starting point: https://vuejs.org/v2/cookbook/packaging-sfc-for-npm.html
Instead of buble we want use babel ( latest version ) and serving all possible format.
Bundle size is a crucial part, so make attention to preset of babel. ( Advice use bugfixes
Minification must be delegated to the terser plugin.

Thanks in advance to all who will contribute to this Issue.
For any question, let we know
@Remeic Remeic added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest label for hacktoberfest event labels Oct 3, 2020
@khamer khamer linked a pull request Oct 3, 2020 that will close this issue
Open
@khamer
Copy link

khamer commented Oct 3, 2020

Just made the above PR (#28) for this. Because you're not using an SFC, it's a bit different than the cookbook but I just based it on how I've solved this before using rollup. Let me know if there's any feedback or issues.

@Remeic Remeic linked a pull request Oct 4, 2020 that will close this issue
switch build to rollup from bili #28
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khamer khamer

Labels
good first issue Good for newcomers hacktoberfest label for hacktoberfest event help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch build to rollup from bili khamer/vue-highlighter
2 participants
@khamer @Remeic