Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Request: implement eslint-plugin-react rules #9

Closed
12 of 20 tasks
SukkaW opened this issue Oct 23, 2023 · 7 comments
Closed
12 of 20 tasks

Rule Request: implement eslint-plugin-react rules #9

SukkaW opened this issue Oct 23, 2023 · 7 comments
Assignees
Labels
Type: Enhancement Enhancements to existing features

Comments

@SukkaW
Copy link
Contributor

SukkaW commented Oct 23, 2023


  • Add all rules implementation to rules exports
  • Link all rules implementation documentation to README.md

  • jsx/no-script-url: Custom Component and prop support
@Rel1cx Rel1cx added the Type: Enhancement Enhancements to existing features label Oct 23, 2023
@Rel1cx
Copy link
Owner

Rel1cx commented Oct 23, 2023

Will be added to the pending list.

@SukkaW
Copy link
Contributor Author

SukkaW commented Oct 23, 2023

Will be added to the pending list.

@Rel1cx Let's just track them right here then. I will start porting those rules when I get time.

@Rel1cx
Copy link
Owner

Rel1cx commented Oct 23, 2023

Will be added to the pending list.

@Rel1cx Let's just track them right here then. I will start port those rules when I get time.

jsx/enforce-jsx-key has been implemented by the three rules

  • jsx/no-missing-key
  • jsx/no-duplicate-key
  • jsx/no-array-index-key
    Except "before-spread", the implementation of these three rules can detect more problems than the original rules.
    If necessary, we can also add a jsx/ensure-key-before-spread

@Rel1cx
Copy link
Owner

Rel1cx commented Oct 23, 2023

Some differences between eslint-plugin-react and @eslint-react regarding jsx-key rules

277427415-b3bda7c0-ddd7-4efc-a1a9-8f20363f105f Xnip2023-10-24_02-13-58

@Rel1cx
Copy link
Owner

Rel1cx commented Oct 23, 2023

And no-object-type-as-default-prop already implemented and covered by no-unstable-default-props

@hyoban
Copy link
Contributor

hyoban commented Oct 24, 2023

naming-convention/filename-extension already implemented by naming-convention/filename-extension

@SukkaW SukkaW removed their assignment Oct 25, 2023
@Rel1cx Rel1cx self-assigned this Nov 3, 2023
@Rel1cx
Copy link
Owner

Rel1cx commented Nov 5, 2023

Since many rules has been changed, we track the migration status in #85.

@Rel1cx Rel1cx closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Enhancements to existing features
Projects
None yet
Development

No branches or pull requests

3 participants