Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/jsx-props-no-spreading ··············-> @eslint-react/jsx/no-spreading-props #102

Closed
Tracked by #85
Rel1cx opened this issue Nov 10, 2023 · 5 comments
Assignees
Labels
Wontfix This will not be worked on

Comments

@Rel1cx
Copy link
Owner

Rel1cx commented Nov 10, 2023

No description provided.

@Rel1cx Rel1cx added the Type: Enhancement Enhancements to existing features label Nov 10, 2023
@hyoban
Copy link
Contributor

hyoban commented Nov 10, 2023

Regarding this rule, do we need the original option? My preference now is to make it completely non-configurable, emitting a warning at all times.

https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-spreading.md#rule-options

@Rel1cx
Copy link
Owner Author

Rel1cx commented Nov 10, 2023

Regarding this rule, do we need the original option? My preference now is to make it completely non-configurable, emitting a warning at all times.

jsx-eslint/eslint-plugin-react@master/docs/rules/jsx-props-no-spreading.md#rule-options

True, no options, warning then don't put in recommended presets

@Rel1cx Rel1cx added needs investigation and removed Type: Enhancement Enhancements to existing features labels Nov 10, 2023
@Rel1cx
Copy link
Owner Author

Rel1cx commented Nov 10, 2023

https://github.com/search?q=react%2Fjsx-props-no-spreading&type=code&p=1

In fact, after investigating the use of this rule in a production environment, I don't think we should migrate it now 😆.

@Rel1cx
Copy link
Owner Author

Rel1cx commented Nov 10, 2023

Closed it for now, reopen it if needed in the future.

@Rel1cx Rel1cx closed this as completed Nov 10, 2023
@Rel1cx Rel1cx reopened this Nov 10, 2023
@Rel1cx Rel1cx closed this as completed in f651c53 Nov 10, 2023
@Rel1cx
Copy link
Owner Author

Rel1cx commented Nov 10, 2023

I've replaced this rule with a couple of rules, which aren't exactly equivalent but are more practical.

@Rel1cx Rel1cx added Wontfix This will not be worked on and removed needs investigation labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants