Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win metrics causing clipping #33

Closed
m4rc1e opened this issue Nov 18, 2016 · 4 comments
Closed

Win metrics causing clipping #33

m4rc1e opened this issue Nov 18, 2016 · 4 comments
Assignees

Comments

@m4rc1e
Copy link
Contributor

m4rc1e commented Nov 18, 2016

Hey,

The Win Metrics are causing clipping in Window's applications. The spec is a rather interesting read for these values. At GF it is policy to make the win Ascent and win Descent the ymin, ymax of the font's bbox. I've peiced together a quick glyphsapp script to report the ymin, ymax in Glyphsapp for a source file.

screen shot 2016-11-18 at 13 08 50

Remember that radically changing these values may upset users and cause their documents to overflow. I can write more on this soonish.

Cheers,
Marc

@davelab6
Copy link

I suggest making the change even if it is disruptive for users because clipping or cutting off essential parts of the letters is never going to get better for readers of those glyphs, but a little reflow can be worked around 😄

@DelveFonts
Copy link
Collaborator

Thank you @m4rc1e for pointing this out and @davelab6 for weighing in. We will review and determine the appropriate revisions to make for this.

@DelveFonts DelveFonts self-assigned this Nov 18, 2016
@andyfitzsuse
Copy link
Contributor

I'm okay for reflow also; almost all of our uses are purely as webfonts with pretty robust layout rules.

@DelveFonts
Copy link
Collaborator

Fixed! New versions are on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants