Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RHINENG-8333): correct ouia-type empty state #817

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix(RHINENG-8333): correct ouia-type empty state #817

merged 1 commit into from
Oct 25, 2024

Conversation

LightOfHeaven1994
Copy link
Contributor

@LightOfHeaven1994 LightOfHeaven1994 commented Oct 21, 2024 •
edited
Loading

some tests are failing because FEC utils haven't been updated yet RedHatInsights/frontend-components#2085

@LightOfHeaven1994 LightOfHeaven1994 requested a review from a team as a code owner October 21, 2024 22:20
@johnsonm325
Copy link
Contributor

/retest

@LightOfHeaven1994
Copy link
Contributor Author

/retest

it will fail until ocp-advisor update frontend-components version as it contains some changes for cypress utils RedHatInsights/frontend-components#2085

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the RHINENG-8333 branch 2 times, most recently from 1951594 to 78d2379 Compare October 25, 2024 14:11
@LightOfHeaven1994 LightOfHeaven1994 enabled auto-merge (squash) October 25, 2024 14:11
@LightOfHeaven1994
Copy link
Contributor Author

so finally I made it work, had to bump utils package too and added redux-mock-store package to dev dependencies otherwise cypress tests were failing locally and on Travis.
I also had to fix cypress tests for bulk select as structure looks correct now for bulk menu list and tests have to be updated

@LightOfHeaven1994 LightOfHeaven1994 enabled auto-merge (squash) October 25, 2024 21:10
@LightOfHeaven1994 LightOfHeaven1994 merged commit 1d7ef83 into RedHatInsights:master Oct 25, 2024
3 of 5 checks passed
@gkarat
Copy link
Collaborator

gkarat commented Oct 25, 2024

🎉 This PR is included in version 1.45.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leSamo leSamo leSamo approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LightOfHeaven1994 @johnsonm325 @gkarat @leSamo