Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHINENG-8850): add objects name to the modal #763

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

Fewwy
Copy link
Collaborator

@Fewwy Fewwy commented Jul 3, 2024

https://issues.redhat.com/browse/RHINENG-8850
You can test both versions of the table by changing objectsWithNames value from true to false.

New version of the table
image

@Fewwy Fewwy requested a review from a team as a code owner July 3, 2024 13:24
@Fewwy Fewwy self-assigned this Jul 3, 2024
@Fewwy Fewwy added the enhancement New feature or request label Jul 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 11.86441% with 52 lines in your changes missing coverage. Please review.

Project coverage is 7.66%. Comparing base (e1c6dc7) to head (106aaf9).
Report is 3 commits behind head on master.

Files Patch % Lines
src/Components/ObjectsModal/ObjectsModal.cy.js 0.00% 25 Missing ⚠️
.../Components/ObjectsModalTable/ObjectsModalTable.js 0.00% 15 Missing ⚠️
src/Utilities/Workloads.js 46.66% 8 Missing ⚠️
...ts/ExpandedRulesDetails.js/ExpandedRulesDetails.js 0.00% 2 Missing ⚠️
src/Components/ObjectsModal/ObjectsModal.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #763      +/-   ##
=========================================
- Coverage    7.69%   7.66%   -0.04%     
=========================================
  Files          68      68              
  Lines        3885    3928      +43     
  Branches      837     849      +12     
=========================================
+ Hits          299     301       +2     
- Misses       3586    3627      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fewwy Fewwy requested review from gkarat and a team July 4, 2024 17:25
@Fewwy
Copy link
Collaborator Author

Fewwy commented Jul 4, 2024

/retest

1 similar comment
@Fewwy
Copy link
Collaborator Author

Fewwy commented Jul 4, 2024

/retest

Copy link
Collaborator

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fewwy

@Fewwy Fewwy merged commit e477e52 into RedHatInsights:master Jul 15, 2024
2 checks passed
@gkarat
Copy link
Collaborator

gkarat commented Jul 15, 2024

🎉 This PR is included in version 1.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants