fix(RecsListTable) useState hook to distinguish safe for test state #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated failing test because sorting was changed
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 76.53% 76.60% +0.07%
==========================================
Files 27 27
Lines 976 979 +3
Branches 362 362
==========================================
+ Hits 747 750 +3
Misses 229 229
Continue to review full report at Codecov.
|
gkarat
pushed a commit
that referenced
this pull request
Apr 11, 2022
## [1.3.4](v1.3.3...v1.3.4) (2022-04-11) ### Bug Fixes * **Recommendations list table:** set OUIA test-safe attribute ([#204](#204)) ([b49dc20](b49dc20))
|
🎉 This PR is included in version 1.3.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
< Table ouiaSafe={testSafe} / > doesn't work it is always equal to true
OuiaSafe property is not described in the patternfly docs so I created an issue in their repository
We need to wait for their answer to understand it better
patternfly/patternfly-react#7185
If it won't get fixed we can add a custom property to the elements to distinguish that it's ready to test them
OR
use refs to add some "test ready flag" to the DOM elements