Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative DNS records for Gandi #246

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Use relative DNS records for Gandi #246

merged 1 commit into from
Apr 14, 2023

Conversation

debovema
Copy link
Contributor

@debovema debovema commented Jan 3, 2023

Description

Fixes for Gandi DNS provider introduced by #233.
I did use the relative name for DNS record in letsencrypt role but not in public_dns one. My tests were OK because of old records in my zone created manually 😊

Checklist/ToDo's

  • Added documentation?
  • Added release note entry? ( docs/release-notes.md )
  • Tested?

@rbo
Copy link
Contributor

rbo commented Jan 9, 2023

/test

@rbo rbo changed the base branch from master to devel January 15, 2023 16:48
@rbo
Copy link
Contributor

rbo commented Jan 15, 2023

Why you are changing from pd_public_domain to cluster_name , pd_public_domain is the right variable?

@rbo rbo self-requested a review January 16, 2023 10:32
@rbo rbo marked this pull request as draft January 16, 2023 10:33
@debovema
Copy link
Contributor Author

debovema commented Feb 7, 2023 •
edited
Loading

Why you are changing from pd_public_domain to cluster_name , pd_public_domain is the right variable?

cluster_name is the right variable. The Gandi provider use relative record like the Azure one for instance here

@debovema debovema marked this pull request as ready for review February 7, 2023 14:16
@debovema
Copy link
Contributor Author

debovema commented Apr 3, 2023

Can it be merged please ? 😄

@rbo
Copy link
Contributor

rbo commented Apr 14, 2023

Why you are changing from pd_public_domain to cluster_name , pd_public_domain is the right variable?

cluster_name is the right variable. The Gandi provider use relative record like the Azure one for instance here

Got it, I don't like this in azure either. And git blame says it's from me :-D

@rbo
Copy link
Contributor

rbo commented Apr 14, 2023

/retets

@rbo
Copy link
Contributor

rbo commented Apr 14, 2023

/retest

@rbo
Copy link
Contributor

rbo commented Apr 14, 2023

/test

@rbo rbo merged commit 7ac55e2 into RedHat-EMEA-SSA-Team:devel Apr 14, 2023
@rbo
Copy link
Contributor

rbo commented Apr 14, 2023

Merged into devel will be merged into master with #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbo rbo rbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debovema @rbo