Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gandi DNS provider #233

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

debovema
Copy link
Contributor

@debovema debovema commented Dec 8, 2022

Description

Checklist/ToDo's

  • Added documentation? Yes, the same as for other providers
  • Added release note entry? ( docs/release-notes.md )
  • Tested?

@debovema debovema marked this pull request as ready for review December 8, 2022 13:26
@rbo
Copy link
Contributor

rbo commented Dec 12, 2022

@debovema Can you be so kind and update (rebase) to the latest devel tree version?

@debovema debovema force-pushed the dns-gandi branch 3 times, most recently from ee8da3a to b76c2df Compare December 12, 2022 14:24
@debovema
Copy link
Contributor Author

@debovema Can you be so kind and update (rebase) to the latest devel tree version?

Done

@rbo
Copy link
Contributor

rbo commented Dec 12, 2022

/test

@skull-cicd
Copy link

skull-cicd bot commented Dec 12, 2022

💀 There was an error during pre-commit / linter:

[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git:.[community,yamllint].
[INFO] Installing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Ansible-lint.............................................................Failed
- hook id: ansible-lint
- exit code: 2

[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
WARNING  Loading custom .yamllint config file, this extends our internal yamllint config.
WARNING  Listing 3 violation(s) that are fatal
yaml: wrong indentation: expected 6 but found 4 (indentation)
ansible/roles/letsencrypt/tasks/main.yml:154

yaml: wrong indentation: expected 6 but found 4 (indentation)
ansible/roles/public_dns/tasks/create-gandi.yml:9

yaml: wrong indentation: expected 6 but found 4 (indentation)
ansible/roles/public_dns/tasks/create-gandi.yml:26

You can skip specific rules or tags by adding them to your configuration file:
# .ansible-lint
warn_list:  # or 'skip_list' to silence them completely
  - yaml  # Violations reported by yamllint

Finished with 3 failure(s), 0 warning(s) on 159 files.

@debovema
Copy link
Contributor Author

/test

@rbo
Copy link
Contributor

rbo commented Dec 12, 2022

/test

@debovema Mh I have to improve the /test /retest is allowed as long as an Owner / Me approved it ones.

@rbo
Copy link
Contributor

rbo commented Dec 12, 2022

If you like you can run it local:

pip install pre-commit
pre-commit run --all-files

@rbo
Copy link
Contributor

rbo commented Dec 14, 2022

/ok-to-test

@debovema
Copy link
Contributor Author

/test

@rbo rbo merged commit 3a19f04 into RedHat-EMEA-SSA-Team:devel Dec 16, 2022
@debovema debovema mentioned this pull request Jan 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants