Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF will gracefully be removed from available list #81

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

ldklenner
Copy link
Contributor

No description provided.

@ldklenner
Copy link
Contributor Author

ldklenner commented Aug 22, 2019

@stefanbschneider, that should resolve the key error from #78, while including all processing SFs in the resource consumption.

Copy link
Member

@stefanbschneider stefanbschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

This allows to finish flows to process when its VNF is removed from the placement, while still accounting for VNF resources while it's stopping "gracefully".

What about newly scheduled flows? Can they be scheduled and start processing at a VNF that's still available but already removed from the placement? This should not be allowed. (Also shouldn't happen anyways because the algorithm shouldn't send flows where it didn't place VNFs.)

@ldklenner
Copy link
Contributor Author

What about newly scheduled flows? Can they be scheduled and start processing at a VNF that's still available but already removed from the placement?

No, this cannot happen as process_flow will first check if the requested SF is in the placement. Available SF will only be used to record current load.

@stefanbschneider stefanbschneider merged commit 26dcf7c into RealVNF:master Aug 23, 2019
@ldklenner ldklenner deleted the dev-fix-available branch August 23, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants