Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge PR BA Lars #135

Closed
stefanbschneider opened this issue Mar 31, 2020 · 2 comments · Fixed by #137
Closed

Merge PR BA Lars #135

stefanbschneider opened this issue Mar 31, 2020 · 2 comments · Fixed by #137
Assignees
@adnan904
Labels
enhancement New feature or request
Milestone
2020-04: Improve ...

Comments

@stefanbschneider
Copy link
Member

See Lars' Klenners work & merge what's useful (feel free to discuss): #117

His implementation has:

  • Flows with egress nodes
  • Link caps
  • Call-per-flow mechanics
  • Better docs
@stefanbschneider stefanbschneider added the enhancement New feature or request label Mar 31, 2020
@adnan904 adnan904 self-assigned this Apr 1, 2020
@stefanbschneider
Copy link
Member Author

This is the repo, where I copied the code. I also made small adjustments to the simulator and algorithms (no functionally breaking changes).

Probably makes sense to check the code here: https://github.com/CN-UPB/distributed-coordination

@stefanbschneider
Copy link
Member Author

Actually, better check my fork: https://github.com/CN-UPB/distributed-coordination/tree/dev

I made a few minor changes there. Nothing spectacular.

@adnan904 adnan904 mentioned this issue Apr 14, 2020
Merged
@stefanbschneider stefanbschneider changed the title Merge PR BA Lars Klenner Merge PR BA Lars May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adnan904 adnan904

Labels
enhancement New feature or request
Projects
None yet
Milestone
2020-04: Improve Simulator & DDPG
Development

Successfully merging a pull request may close this issue.

Adding the eggress node handling functionality adnan904/coord-sim
2 participants
@stefanbschneider @adnan904