Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript errors not reported in tests #3166

Closed
cartant opened this issue Dec 5, 2017 · 4 comments
Closed

TypeScript errors not reported in tests #3166

cartant opened this issue Dec 5, 2017 · 4 comments
Labels
feature PRs and issues for features help wanted Issues we wouldn't mind assistance with.

Comments

@cartant
Copy link
Collaborator

cartant commented Dec 5, 2017

TypeScript errors are not being reported by the tests, so all of the tests within the type() tests are ineffectual.

RxJS version: current master

Code to reproduce:

Adding an incorrectly typed constant to debounce-spec.ts, say, like this:

import { expect } from 'chai';
import * as Rx from '../../src/Rx';
import marbleTestingSignature = require('../helpers/marble-testing'); // tslint:disable-line:no-require-imports

const n: number = "1"; // Obviously an error

should effect a TypeScript error, but it does not.

Expected behavior:

An error should be reported and the tests should fail.

Actual behavior:

No error is reported

Additional information: -

@kwonoj
Copy link
Member

kwonoj commented Dec 5, 2017

I accidently close issue, it's #3020. basically we don't run compiler to specs yet.

@kwonoj kwonoj added help wanted Issues we wouldn't mind assistance with. feature PRs and issues for features labels Dec 5, 2017
@cartant
Copy link
Collaborator Author

cartant commented Dec 5, 2017

I see. No worries.

@cartant
Copy link
Collaborator Author

cartant commented Mar 8, 2018

Closing in favour of #3411.

@cartant cartant closed this as completed Mar 8, 2018
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature PRs and issues for features help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Development

No branches or pull requests

2 participants