Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Set polyfill #2467

Closed
benlesh opened this issue Mar 15, 2017 · 3 comments
Closed

Remove Set polyfill #2467

benlesh opened this issue Mar 15, 2017 · 3 comments

Comments

@benlesh
Copy link
Member

benlesh commented Mar 15, 2017

We're currently polyfilling Set for everyone, really only to support distinct. I'd like in the spirit of #2407, I'd liek to propose removing the Set polyfill entirely, placing the onus on developers targeting IE10 and lower to provide their own polyfill.

Pros

  1. Smaller library size
  2. Less to maintain
  3. I suspect the native Set impls may have better performance
  4. All "modern" browsers support Set, it seems

Cons

  1. Definitely a breaking change
  2. I'm unsure if there are any quirks to this functionality between browser versions in the wild.
  3. Might hurt more esoteric JS runtime targets (ala SmartTVs at Netflix?)
@trxcllnt
Copy link
Member

👍 ⚡️

@kwonoj
Copy link
Member

kwonoj commented Feb 21, 2018

I believe this is done via #3040.

@kwonoj kwonoj closed this as completed Feb 21, 2018
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trxcllnt @kwonoj @benlesh