Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rc.1] do operator breaks types. / Subjects need asObservable to keep types. #2029

Closed
ovrmrw opened this issue Oct 13, 2016 · 5 comments
Closed

Comments

@ovrmrw
Copy link

ovrmrw commented Oct 13, 2016

RxJS version: 5.0.0-rc.1

Code to reproduce: https://github.com/ovrmrw/rxjs-marble-tests/blob/master/spec/forIssues/rc1-unexpected-behavior.ts

Expected behavior: asObservable is not needed for Subjects just to keep variable types. do operator should not break variable types.

Actual behavior: Subjects without asObservable all turn variable types into "any". do operator turns variable types into "{}".

Additional information: TypeScript 2.0.3 , VSCode 1.6.0

@david-driscoll
Copy link
Member

This should be fixed with #2022

@ovrmrw
Copy link
Author

ovrmrw commented Oct 14, 2016

do operator is ok by #2222.
But an issue that Subject needs asObservable to keep types is still a problem.

@ovrmrw
Copy link
Author

ovrmrw commented Oct 14, 2016

I confirmed to be solved the Subject issue. Great work! Should I close this issue?

@kwonoj
Copy link
Member

kwonoj commented Oct 25, 2016

Closing via #2035 .

@kwonoj kwonoj closed this as completed Oct 25, 2016
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants