From c9ea2b0fd45d6ca41ab8370231ee1a2503757fa9 Mon Sep 17 00:00:00 2001 From: Ben Lesh Date: Wed, 26 Aug 2020 11:27:37 -0500 Subject: [PATCH] chore: update comment --- src/internal/Observable.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/internal/Observable.ts b/src/internal/Observable.ts index 9cbe534be9..e66d18a8f6 100644 --- a/src/internal/Observable.ts +++ b/src/internal/Observable.ts @@ -252,10 +252,8 @@ export class Observable implements Subscribable { if (canReportError(sink)) { sink.error(err); } else { - // This is hit when the user develops a poorly made observable. That means that - // something is calling `subscriber.error` more than once. We're currently logging - // this as a warning to console to let them know something is wrong. - // TODO: Remove this in favor of some sort of reporting handle. + // If an error is thrown during subscribe, but our subscriber is closed, so we cannot notify via the + // subscription "error" channel, we are warning the developer of the problem here, via the console. console.warn(err); } }