You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Calling combineLatest from Kotlin is a bit awkward. The function has a lot of different parameters, including Iterable, Array as well as 2-x call sites for passing multiple Observables.
Is it possible to prefix these so we have some kind of combineLatestFromIterable which takes the Iterable<T>:
combineLatestArray would be reasonable and match the other xArray method names. What's the conflict between combineLatest(Iterable, F) and combineLatest(O1, O2, F2)?
There should not be any issues with combineLatest(Iterable, F) and combineLatest(O1, O2, F2). I'd just go for consistency. Looking at startWithIterable.
startWithIterable was disambiguated due to startWith(Publisher) and/or startWith(T) so I'd say is an exception. So if the main trouble is with combineLatest(O[], F) then let's rename that to combineLatestArray.
zip could use some name clarification too. There is zip(Iterable(P), F), zipIterable(Iterable(P), bool, int, F), zipArray(F, O...), zip(P(P)).
Calling
combineLatest
from Kotlin is a bit awkward. The function has a lot of different parameters, including Iterable, Array as well as 2-x call sites for passing multiple Observables.Is it possible to prefix these so we have some kind of
combineLatestFromIterable
which takes theIterable<T>
:and then
combineLatest
which takes the 2-x call sites.The array call we could call
combineLatestFromArray
.What should we do with?
Is it really required? Callers could just use the array overload.
combineLatestDelayError
is equivalent and could get the method name improvements as well.Other methods, such as concat/merge could benefit from this change too.
The text was updated successfully, but these errors were encountered: