Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rx 2.x SingleMap should not allow null mapper? #5376

Closed
kojilin opened this issue May 30, 2017 · 2 comments
Closed

Rx 2.x SingleMap should not allow null mapper? #5376

kojilin opened this issue May 30, 2017 · 2 comments

Comments

@kojilin
Copy link
Contributor

kojilin commented May 30, 2017

RxJava 2.0.8

Found code like below can works

Single.just("1234").map(s -> null)
              .subscribe(s -> {
                  System.out.println(s);
              });

Because Single#just not allow null, so SingleMap should not allow it?
should like this? https://github.com/ReactiveX/RxJava/compare/2.x...kojilin:FIX-NPE?expand=1

@davidmoten
Copy link
Collaborator

Your PR looks good to me, I'd say submit it but remember to remove the "Thank you contributing..." template from the description.

@akarnokd
Copy link
Member

Closing via #5378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants