bug(YouTube): 'Custom branding' and 'Change header' does not fully applied

[cyberboh]

Bug description

So, i built the patches myself, using dev branch as source and from the commit d36ede0 then updated to the commit 7ccfa57
Built successfull and i patched YT 19.43.41 using this command:

java -jar revanced-cli-5.0.0-dev.8-all.jar patch -p patches-5.0.0-dev.1.rvp --keystore-entry-alias=alias --keystore-password=password --keystore-entry-password=password --keystore=revanced.keystore -e "Custom branding" -OappName=YouTube -e "Change header" -Oheader=premium*header Apps\com.google.android.youtube-19.43.41-all.apk -o Install\YouTube_19.43.41-all_ReVanced.apk

All patches applied, no errors occured. App name also changed to YouTube, but it is still using default YouTube logo. Also, it still using default YouTube header.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[LisoUseInAIKyrios]

Add quotes to the options:

-OappName="YouTube" -Oheader="premium*header"

[oSumAtrIX]

The quotes are not necessary as the CLI parser parses the value entirely as a string since there's no space or quotation. The CLI parser does parse the options also correctly, so this may be an issue with the patches.

[oSumAtrIX]

Though, the patch seems to work as expected:

[LisoUseInAIKyrios]

I get an error if using -Oheader=premium*header, but that's only because of the * wildcard causes the shell to think it's an expansion operator.

[LisoUseInAIKyrios]

Hmmm. It seems the custom branding patch applies the app name, but the icon is not applied.

[oSumAtrIX]

The patch changed the assets for me just fine.

[LisoUseInAIKyrios]

With custom branding did the app icon change to the ReVanced icon? I am still seeing the original app icon.

[LisoUseInAIKyrios]

@oSumAtrIX try patching 19.43.41 with custom branding. It looks like the launcher icon file name was changed with 19.43.41

[oSumAtrIX]

The logo was changed by the patch:

I have not tested if it appears though when installed. Perhaps this is a new change by YouTube and there are new paths that need to be patched as well.

[oSumAtrIX]

@oSumAtrIX try patching 19.43.41 with custom branding. It looks like the launcher icon file name was changed with 19.43.41

You are right. There are new file names

[LisoUseInAIKyrios]

19.43.41 uses launcher file ringo2_ic_launcher.xml,
and the icon files are:

@mipmap/adaptiveproduct_youtube_2024_q4_foreground_color_108
@mipmap/adaptiveproduct_youtube_2024_q4_background_color_108

[oSumAtrIX]

The patch does need adjustment to support these. They also seem to have a specific scaling which is annoying as I am not sure what factor for the scale is used.

[LisoUseInAIKyrios]

I think the simplest fix is if a custom icon is used, then change the manifest entry for the icon back to the old 19.34 value.

Edit: the old ic_launcher_round file is gone, so using the old icon xml file won't work.

[oSumAtrIX]

Actually, I think this file can be copied to the new path:

[cyberboh]

Confirmed solved in https://github.com/ReVanced/revanced-patches/releases/tag/v5.0.0-dev.1

[MarcaDian]

Some users write that there are problems with Change header, at first launch it displays the Revanced header, and when a new layout is loaded from the server, the header changes to the standard one.
If update the installed patched app, everything displays as it should.

v5.0.1, 19.43.41

[LisoUseInAIKyrios]

It's probably an a/b test for a different header layout.

If anyone can reproduce the issue, then they can turn on debugging and filter the adb logs for debuggingpatch, and that'll show what a/b flags are on and the correct flag can be identified and patched.

[cyberboh]

It's probably an a/b test for a different header layout.

If anyone can reproduce the issue, then they can turn on debugging and filter the adb logs for debuggingpatch, and that'll show what a/b flags are on and the correct flag can be identified and patched.

Can you specify full commmand for debugging? I think i have the issue. 'Premium' logo becomes original one.

[MarcaDian]

Or simply adb logcat > log.txt

[LisoUseInAIKyrios]

Doing a full log dump will include logs for all apps (and may include private information).

Windows:
adb logcat | findstr "DebuggingPatch" > log.txt

Unix / MacOS:
adb logcat | grep "DebuggingPatch" > log.txt

[cyberboh]

Nothing in the logs about change header Or DebuggingPatch, may be it needs same fix as custom branding.

more_drawer.eml|7ba9a521fa269e52*❙Innertube❙yt_ringo2_wordmark_header_light❙Innertube❙yt_ringo2_wordmark_header_dark❙Trending❙yt_outline_fire_black_24❙FEtrending❙

[LisoUseInAIKyrios]

There should be dozens of lines with DebuggingPatch.

[cyberboh]

There should be dozens of lines with DebuggingPatch.

I only get these lines:

11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: boolean feature is enabled: 45401569
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: java.lang.Throwable
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at app.revanced.extension.shared.Logger.printDebug(Logger.java:75)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at app.revanced.extension.shared.Logger.printDebug(Logger.java:59)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at app.revanced.extension.youtube.patches.EnableDebuggingPatch.isBooleanFeatureFlagEnabled(EnableDebuggingPatch.java:21)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at abdp.s(PG:15)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at abdp.J(PG:5)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at gyl.call(PG:159)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bdai.N(PG:3)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcbq.M(PG:13)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bdbi.N(PG:11)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcbq.M(PG:13)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bdaf.N(PG:73)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcbq.M(PG:13)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcqa.V(PG:8)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcaz.U(PG:13)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcqo.V(PG:11)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcaz.U(PG:13)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcsj.f(PG:99)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcsj.pr(PG:6)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcuv.pr(PG:23)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcxd.pr(PG:3)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcwx.pr(PG:15)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcwi.pr(PG:30)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcxd.pr(PG:3)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcwx.pr(PG:15)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bctl.e(PG:81)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bctk.pr(PG:44)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bceq.f(PG:32)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bdbw.py(PG:1)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcgu.c(PG:53)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcfr.py(PG:3)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcup.pr(PG:24)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bcut.pr(PG:15)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bdem.b(PG:22)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bdfj.a(PG:7)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bdfj.c(PG:55)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at bdfk.pr(PG:34)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at ymq.C(PG:264)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at yms.i(PG:3)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at yms.j(PG:8)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at ggz.q(PG:3)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at gao.run(PG:638)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at ggs.e(PG:55)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at ggs.g(PG:3)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at ajzt.aG(PG:13)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at ggs.f(PG:1)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at aips.f(PG:19)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at rzw.c(PG:38)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at esg.g(PG:196)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at ahqn.run(PG:87)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at android.os.Handler.handleCallback(Handler.java:900)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at android.os.Handler.dispatchMessage(Handler.java:103)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at android.os.Looper.loop(Looper.java:219)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at android.app.ActivityThread.main(ActivityThread.java:8668)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at java.lang.reflect.Method.invoke(Native Method)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
11-13 10:18:07.766 12428 12428 D revanced: EnableDebuggingPatch: 	at 

[LisoUseInAIKyrios]

You'll need to force stop the app and relaunch to see all the flags. On launch I see 175 log statements for the debugging patch.

You can also turn off stack trace logging as it's not useful here.