sync changelogger settings across devices

[kinghat]

would like to sync the settings across devices if you would accept of pr when i get around to it?

[Rayquaza01]

Sure, I'll accept the PR if you make one

[kinghat]

i forgot to update the readme > options > theme documentation in the PRs

[Rayquaza01]

That's fine, I can add that myself. The extension/docs/help.html also needs to be updated.

[kinghat]

The extension/docs/help.html also needs to be updated.

if you remove the theme section from this ill apply the styling/theme media queries to this as well, to bring it all together, later this afternoon or tomorrow.

[Rayquaza01]

I ended up removing the help page and moving most of the unique points it had into the README. It mainly said the same things as the README anyway.

I also did a decent bit of work cleaning up the code (adding comments, fixing the race condition bug, updating the AMO API version, converting to TypeScript, etc.) on the feature branch. I think it's pretty much ready to go, but I'd be happy to hear if you would like to make any changes/suggestions before I submit it.

[kinghat]

oh neat, ive been learning the basics of TS recently. i will give it a look over and see what you've done. i appreciate you valuing my opinion on the project 🙏

[kinghat]

looked over the feature branch rewrite, it looks really clean and i learned some things. first time seeing a semaphore. is that the fix for the race condition bug? i tested it a bit and didnt find any issues. theres no easy way to see the sync storage area or test the sync api though 🤷‍♂️ thanks for your work on refactoring the project!

superficially "updated" here could be "shown":

changelogger/src/pages/options/options.html

Line 11 in 220187d

<p>Should the icon badge be updated when an extension is updated?</p>

and the corresponding interface comment:

changelogger/src/OptionsInterface.ts

Line 2 in 220187d

/** Should the icon badge be updated when an extension is updated? */

[Rayquaza01]

Yes, the semaphore is the fix for the race condition bug. Saving the changelog to storage is actually 3 smaller steps, reading the current list, updating the list, and writing the new list. Because the WebExtension storage API is async, if 2+ extensions were installed/updated at basically the same time, the steps might execute out of order, causing some of the changelogs to not actually be saved. The semaphore "locks" storage so that it's guaranteed that only one changelog can be written at once, and that any others trying to access storage will have to wait for the lock to be released.

Good catch on that comment, it makes more sense as "shown".

And thanks again for your help on this version! I really appreciate it!

[Rayquaza01]

The new version should be up on AMO now. That was faster than expected! It only took 4 minutes for the submission to be approved.

[kinghat]

very nice. just came through for me and updated nicely. enjoy your week!