Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup doesnt show if a changelog contains a link to AMO #5

Closed
kinghat opened this issue Nov 13, 2019 · 1 comment
Closed

popup doesnt show if a changelog contains a link to AMO #5

kinghat opened this issue Nov 13, 2019 · 1 comment
Labels

Comments

@kinghat
Copy link
Contributor

kinghat commented Nov 13, 2019

ive done zero research on this but i just had an extension that was disabled get updated and now the popup doesnt show. havent tried restarting the browser yet. just documenting for now:

image

@Rayquaza01 Rayquaza01 added the bug label Nov 13, 2019
@Rayquaza01
Copy link
Owner

This is a bug, but not because the extension was disabled when it updated.

When there are links in changelogs, the API gives the links so that links to external sites (sites that aren't AMO) go through a redirection server. (Here's an example from the Simple Tab Groups changelog: https://outgoing.prod.mozaws.net/v1/92627baba4be31b5368a286a0e58b18eebd40aadcb009d1b26725e0b92f6ebeb/https%3A//bugzilla.mozilla.org/show_bug.cgi%3Fid=1595583). Changelogger strips the redirect out.

In the changelog for Simple Tab Groups, there's also a link to another page on AMO (https://addons.mozilla.org/firefox/addon/stg-plugin-create-new-tab/). This doesn't have the redirect, so when Changelogger tries to remove the redirect, it breaks.

@Rayquaza01 Rayquaza01 changed the title popup doesnt show on disabled extension update popup doesnt show if a changelog contains a link to AMO Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants