Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to response selector output #5469

Closed
jamesmf opened this issue Mar 24, 2020 · 2 comments
Closed

Add name to response selector output #5469

jamesmf opened this issue Mar 24, 2020 · 2 comments
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@jamesmf
Copy link
Contributor

jamesmf commented Mar 24, 2020

Description of Problem:
The response selector returns the full response, but not the structured "type" of the response

Overview of the Solution:
Add the type of the response to the output (can be named anything meaningful).

Examples (if relevant):

"response_selector": {
        "default": {
            "response": {
                "type": "cats"
                "name": "I see you have a question about cats",
                "confidence": 0.775967896
            }
      }

In this example the responses.md contains a heading for faq/cats that says "I see you have a question about cats". The reason it would be helpful to have the structured name /cats in the response is so that it's easier to use that output elsewhere, instead of having to check for the whole string "I see you have a question about cats."

@jamesmf jamesmf added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Mar 24, 2020
@erohmensing
Copy link
Contributor

Hey @jamesmf! I believe this enhancement was just implemented last week 🙂 if you try out building the master version from source, you can let us know what you think. Or you can wait for the 1.9 release, which should come out this week!

#5432

@jamesmf
Copy link
Contributor Author

jamesmf commented Mar 25, 2020

awesome!

@jamesmf jamesmf closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

2 participants