You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I realized that external tilesets are loaded for each map separately and there is no way to cache them since in your implementation tilesets contain information about first gid. I propose changing Tileset references in ExternalTileset to ITiIeset and make ExternalTileset not propagate the FirstGid property but instead offset the gid in this[int gid].
Also will fork this repo and apply the second change I mentioned (without a PR) because I need this feature for GlobalGameJam which is starting "soon".
The text was updated successfully, but these errors were encountered:
As for the FirstGid property, it's merely matching Tiled's behavior. But if this has changed over the years, I will implement a migration for the version change and adjust the behavior.
That's what I did, but still ExternalTileset would propagate FirstGid to the Tileset and cause errors when reading the tiles.
Also as far as I understand the specification FirstGid is a property present in the map and not the tileset
I realized that external tilesets are loaded for each map separately and there is no way to cache them since in your implementation tilesets contain information about first gid. I propose changing
Tileset
references in ExternalTileset toITiIeset
and makeExternalTileset
not propagate theFirstGid
property but instead offset the gid inthis[int gid]
.Also will fork this repo and apply the second change I mentioned (without a PR) because I need this feature for GlobalGameJam which is starting "soon".
The text was updated successfully, but these errors were encountered: