Added: Remote poster and fanart references to Kodi metadata file (#2837) #3302
Conversation
| details.Add(new XElement("thumb", thumbnail.Url)); | ||
| } | ||
|
|
||
| foreach (var poster in posters) |
There was a problem hiding this comment.
Doesn’t appear multiple entries are supported for posters like fanart? Should we just choose first like is done for screenshots above? Also this needs to be null checked.
There was a problem hiding this comment.
Referring to https://kodi.wiki/view/NFO_files/Movies#Movie_nfo_Tags.
| NFO (xml) Tag | Required | Multiple | Notes |
|---|---|---|---|
<thumb aspect="poster" preview=""></thumb> |
No | Yes | Path to Movie Posters |
This page seems to indicate that multiple movie poster entries are possible in the NFO file. I suspect they are used when the user wants to select an alternative poster in the movie info section. You are right about the null checks; I will add them as soon as I find some tme for it.
|
@RobinQ124274 were you able to add the null checks on this? Might also be able to tack on fix for #3001 while we are working on these files? |
|
@Qstick I added the null checks in the latest commit from my forked repo. However, I got an issue from CodeFactor stating that the method is too complex (i.e. too many code lines)? I am not really comfortable in resolving this CodeFactor issue without any approval, since it would require breaking up the method in several submethods... |
|
@RobinQ124274 Codefactor should be fine, it's probably already an existing issue (you can also try to use c# nullable types, e.g. |
|
@RobinQ124274 does the |
@Qstick |
|
This issue has been automatically marked as stale because it has not had recent activity. Please verify that this is still an issue with the latest version of Radarr and report back. Otherwise this issue will be closed. |
Database Migration
NO
Description
Added remote poster and fanart references to the output of Kodi metadata files. Including these tags allows Kodi to properly differentiate video thumbnails from posters and fixes the issue that some skins would show a video thumbnail instead of the poster because of the empty
<thumb>tag. Fanart entries were included as an extra for completeness.Notes
The metadata file now refers to the remote images from TheMovieDB. Therefore, this solution will not provide the intended result (i.e., using the local image files), but does fix the issue that no posters or fanart are shown in Kodi.
Issues Fixed or Closed by this PR