Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Don’t allow profile delete list #2797

Merged
merged 2 commits into from
May 21, 2018
Merged

Fixed: Don’t allow profile delete list #2797

merged 2 commits into from
May 21, 2018

Conversation

Qstick
Copy link
Member

@Qstick Qstick commented May 21, 2018

Database Migration

NO

Description

  • Fix UI so that Delete button cannot be pressed when disabled.
  • Disable delete in UI if List exists using profile.
  • Block profile deletion in backend if list uses profile.

Issues Fixed or Closed by this PR

Fixes #1540

@galli-leo galli-leo added the Status: In Progress In Progress label May 21, 2018
@Qstick Qstick requested a review from galli-leo May 21, 2018 03:31
@Qstick Qstick changed the title Fix dont allow profile delete list Fixed: Don’t allow profile delete list May 21, 2018
@galli-leo galli-leo merged commit f058b8f into develop May 21, 2018
@galli-leo galli-leo removed the Status: In Progress In Progress label May 21, 2018
@Qstick Qstick deleted the fix-dont-allow-profile-delete-list branch May 25, 2018 00:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@galli-leo galli-leo Awaiting requested review from galli-leo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not allow profile to be deleted if in use with lists.
2 participants
@Qstick @galli-leo