Fixed: Movies not getting unmonitored when folder gets deleted #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichapman
force-pushed
the
fix-unmonitor-on-delete
branch
from
c251141 to
11c9718
Compare
|
I've never thought i see the day. The movie deleted from Plex now gets unmonitored. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
The previously committed fix to the listed issues didn't appear to work, at least for me, so I did some digging and comparisons with Sonarr's behaviour and think this fix should work. It sends the movie through the same route as it does when just the file is deleted - MediaFileTableCleanupService -> MediaFileService -> MovieService, which ends up doing the unmonitor config option check.
Todos
Issues Fixed or Closed by this PR