-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI cleanup, fixes and consistency #1959
Conversation
5a8a7d7
to
8c55d21
Compare
Not that my input is worth much, but I think it's worth continuing. It should look just as beautiful beneath the bonnet... |
Seems worth continuing to me! Let me know when you are finished with this pr, so I can merge it. |
Will do! Thanks. |
c4e3618
to
c0c4341
Compare
@galli-leo The PR as it stands should fix up a lot of the inconsistency in terms of labels, headings etc in the UI. I haven't modified the "TV/Series" stuff as its not used. I guess at some point its probably worth trying to remove some of the unused UI handlebars stuff, but probably not now! I have likely picked off a few issues in general with layout/field appearances in some cases as well, admittedly this PR got massive very quickly, so I'm stopping now to maybe revisit parts in a more section based approach! Because the UI is massive, I'm sure a few visits will be needed to fully get things right, but hopefully this is a good start! I have tried to test sections to ensure I haven't regressed anything, but if you notice anything let me know! |
1bf6751
to
2b56efd
Compare
2b56efd
to
3860ffc
Compare
Thanks a lot! |
@galli-leo. Apologies will review ASAP. |
Database Migration
NO
Description
I'm still working through all the UI elements, but thought I'd push what I've been doing so far. I'm basically going through the handlebars files
.hbs
and fixing up issues where I find them, particularly.aria-hidden
in placesimg
input
fields (HTML 5 doesn't need them)</i>
<div>
elements with</div>
not/>
title
values consistent with punctuationIn addition to the above:
</body>
being closed before JavaScript inindex.html
Let me know if this is something worth continuing!