Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI cleanup, fixes and consistency #1959

Merged
merged 1 commit into from
Aug 20, 2017

Conversation

jamesmacwhite
Copy link
Contributor

@jamesmacwhite jamesmacwhite commented Aug 18, 2017

Database Migration

NO

Description

I'm still working through all the UI elements, but thought I'd push what I've been doing so far. I'm basically going through the handlebars files .hbs and fixing up issues where I find them, particularly.

  • Consistent titles/field values (capitalisation)
    • I think the best rule to follow is write headings/sections title etc that are currently capitalised like "Movie Naming" as "Movie naming" and then CSS to display it as such, because technically, capitalising is styling thing.
  • Improving accessibility with icons aria-hidden in places
  • Trying to get the code consistent with the following rules:
    • No closing tags on img input fields (HTML 5 doesn't need them)
    • Closing icons with </i>
    • Closing <div> elements with </div> not />
  • Making title values consistent with punctuation
  • Fixing hanging tags/syntax issues in places which have gone unnoticed previously
  • Minor grammar alternations in places
  • Fix indentation where needed for better readability.

In addition to the above:

  • Allow 128x128 logo to appear in the medium breakpoint
  • Added woff2 fonts for faster loading in browsers that support it
  • Also fixed the local src name of the Ubuntu Mono regular font
  • Fixed </body> being closed before JavaScript in index.html

Let me know if this is something worth continuing!

@jamesmacwhite jamesmacwhite force-pushed the ui-cleanup-and-fixups branch from 5a8a7d7 to 8c55d21 Compare August 18, 2017 10:00
@mrhotio
Copy link
Contributor

mrhotio commented Aug 18, 2017

Not that my input is worth much, but I think it's worth continuing. It should look just as beautiful beneath the bonnet...

@galli-leo
Copy link
Contributor

Seems worth continuing to me! Let me know when you are finished with this pr, so I can merge it.

@jamesmacwhite
Copy link
Contributor Author

Will do! Thanks.

@jamesmacwhite jamesmacwhite force-pushed the ui-cleanup-and-fixups branch 6 times, most recently from c4e3618 to c0c4341 Compare August 19, 2017 18:09
@jamesmacwhite
Copy link
Contributor Author

jamesmacwhite commented Aug 19, 2017

@galli-leo The PR as it stands should fix up a lot of the inconsistency in terms of labels, headings etc in the UI. I haven't modified the "TV/Series" stuff as its not used. I guess at some point its probably worth trying to remove some of the unused UI handlebars stuff, but probably not now!

I have likely picked off a few issues in general with layout/field appearances in some cases as well, admittedly this PR got massive very quickly, so I'm stopping now to maybe revisit parts in a more section based approach!

Because the UI is massive, I'm sure a few visits will be needed to fully get things right, but hopefully this is a good start!

I have tried to test sections to ensure I haven't regressed anything, but if you notice anything let me know!

@jamesmacwhite jamesmacwhite changed the title [wip] UI cleanup, fixes and consistency UI cleanup, fixes and consistency Aug 19, 2017
@jamesmacwhite jamesmacwhite force-pushed the ui-cleanup-and-fixups branch 10 times, most recently from 1bf6751 to 2b56efd Compare August 20, 2017 10:17
@jamesmacwhite jamesmacwhite force-pushed the ui-cleanup-and-fixups branch from 2b56efd to 3860ffc Compare August 20, 2017 11:28
@galli-leo galli-leo merged commit 0c8e264 into Radarr:develop Aug 20, 2017
@galli-leo
Copy link
Contributor

Thanks a lot!

@galli-leo
Copy link
Contributor

Seems like this pr caused a few ui regressions (See #1984, #1989, #1988) Can you take a look? For now I reverted your commit.

@jamesmacwhite
Copy link
Contributor Author

@galli-leo. Apologies will review ASAP.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants