[MRG] Clean up evaluate_word_pairs code #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpenkov CI fail seems unrelated. Can you check please? |
|
CI is green now, I don't really understand what happened. Anyway, merging! |
|
It's green because I re-ran the failed part only. Sometimes the tests can fail because of a network error installing packages. In that case, re-running the test usually solves the problem. You can re-run by going for the test that failed and selecting "re-run failed jobs" from the widget in the top right corner of the screen. |
|
Interesting. So a problem on Microsoft's side? "Just restart it" follows a time-honoured tradition then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3315.
The code was brittle and failed to check and report on user input properly.