[MRG] Make the link to the Gensim 3.8.3 documentation dynamic #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notification in header of Gensim 4 docs redirects to corresponding page.
|
Makes sense, thanks. I'll try this now. |
|
OK, added to https://radimrehurek.com/gensim/ . I'll wait with the merge for @dvorakvaclav 's review – maybe he can think of a cleaner way. |
piskvorky
changed the title
|
That's a good simple solution. I can't think of a better one. |
|
OK great. @mpenkov feel free to merge once the release is completed. (I don't want to merge anything mid-release) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #2995 by making the "Gensim 3.8.3 documentation" link in the header of the Gensim 4.0.0 documentation redirect the user to the corresponding page in the Gensim 3.8.3 documentation instead of the index page. The changes are confined to the
notification.htmldocument, which makes them easy to undo when we're removing the notification sometime in the future.