Fixes divided by zero when w_star_count==0 #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If w_star_count==0, it will throw exception of divided by zero
|
Thanks for PR @allenyllee 👍 |
piskvorky
reviewed
Jan 11, 2019
| @@ -73,6 +73,9 @@ def log_conditional_probability(segmented_topics, accumulator, with_std=False, w | |||
| m_lc_i = np.log(((co_occur_count / num_docs) + EPSILON) / (w_star_count / num_docs)) | |||
| except KeyError: | |||
| m_lc_i = 0.0 | |||
| except ZeroDivisionError: | |||
| # if w_star_count==0, it will throw exception of divided by zero | |||
There was a problem hiding this comment.
The same is true for num_docs == 0.
@allenyllee @menshikh-iv can you add a comment why m_lc_i = 0.0 is the correct solution when a "division by zero" occurs?
It's not obvious to me why this happens, and why such fix is doing the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If w_star_count==0, it will throw exception of divided by zero