Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsApplicable should not throw exceptions instead of returning false. #2639

Open
atamazov opened this issue Dec 25, 2023 · 2 comments
Open

IsApplicable should not throw exceptions instead of returning false. #2639

atamazov opened this issue Dec 25, 2023 · 2 comments
Assignees
@et16kr @seungmanhan
Labels
bug urgency_high

Comments

@atamazov
Copy link
Contributor

@seungmanhan The helper functions in ProblemDescription classes may throw instead of returning false. This leads to IsApplicable to throw exceptions, which is wrong.

Involved primitives:

  • Reduce
  • Norm

Originally posted by @atamazov in #2481 (comment)
@atamazov
Copy link
Contributor Author

[Attribution] @junliume @JehandadKhan

@atamazov atamazov changed the title IsApplicable should not throw. IsApplicable should not throw exceptions instead of returning false. Dec 25, 2023
@atamazov atamazov mentioned this issue Dec 25, 2023
Merged
@atamazov
Copy link
Contributor Author

In some cases (incorrect ProblemConfig) exceptions are allowed, more info at #2562 (comment)

@CAHEK7 CAHEK7 mentioned this issue Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@et16kr et16kr

@seungmanhan seungmanhan

Labels
bug urgency_high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@junliume @atamazov @et16kr @seungmanhan