Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MLIR enablement heuristic #2296

Open
krzysz00 opened this issue Oct 5, 2023 · 0 comments
Open

Implement MLIR enablement heuristic #2296

krzysz00 opened this issue Oct 5, 2023 · 0 comments
Assignees

Comments

@krzysz00
Copy link
Contributor

krzysz00 commented Oct 5, 2023

Per discussion with @pfultz2 , rocMLIR-based kernel generation will be enabled in the 6.0 release in the following circumstances:

  • Any convolution fusion
  • Any i8 gemm fusion
  • All Navi3x standalone convolutions
  • With a flag that is off by default, fp* gemm fusions

Except:

  • 3x3 winnograd convolutions fusions (except on Navi)
  • K > 2048 on gemm (as for CK)
    • This should be K relative to G * M * N, but if that can't be implemented by release, we'll go for the simple filter

#2274 implements part of this heuristic, but is incomplete (and, for example, doesn't have the "don't skip winnogradable convolutions on Navi" part)

@causten @jerryyin for awareness
If someone could at in Andy (I think) who has the performance measurements scripts for more comments, that'd be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants