Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to message structure 2 from pitipo. #331

Merged
merged 7 commits into from
Mar 15, 2021

Conversation

sepast
Copy link
Contributor

@sepast sepast commented Mar 9, 2021

Updated the pitipo with latest firmware, to solve the leap year bug.
Latest firmware sends data according to Message structure 2.
Maestro needs to be adapted to this and that is solved in this PR.

Copy link
Collaborator

@LukasWikander LukasWikander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor stuff. On an unrelated note: we should move the PiTiPo decoder OMGC uses to util, so we can make use of it elsewhere!

@LukasWikander LukasWikander self-assigned this Mar 10, 2021
@sepast sepast requested a review from LukasWikander March 10, 2021 09:12
@LukasWikander
Copy link
Collaborator

Have you run the code format checker and test scripts locally?

@sepast
Copy link
Contributor Author

sepast commented Mar 11, 2021

Have you run the code format checker and test scripts locally?

Yes I did and it passed with no changes.

@LukasWikander LukasWikander merged commit fd959be into dev Mar 15, 2021
@LukasWikander LukasWikander deleted the feature_NewTimeMessage branch March 15, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants